fix: update maxAllowedRewardShare, maxRts, maxMintingFee, and maxRevenueShare values in group and IP asset tests for improved accuracy and consistency

Author: bonnie57

packages/core-sdk/test/integration/group.test.ts

@@ -151,7 +151,7 @@ describe("Group Functions", () => {
             },
           },
         ],
-        maxAllowedRewardShare: 5,
+        maxAllowedRewardShare: 100,
       });
 
       expect(result.txHash).to.be.a("string");
@@ -172,7 +172,6 @@ describe("Group Functions", () => {
         groupId,
         nftContract: spgNftContract,
         tokenId,
-        maxAllowedRewardShare: 5,
         licenseData: [
           {
             licenseTermsId,
@@ -197,7 +196,7 @@ describe("Group Functions", () => {
     it("should successfully register group with license and add multiple IPs", async () => {
       const result = await client.groupClient.registerGroupAndAttachLicenseAndAddIps({
         groupPool: groupPoolAddress,
-        maxAllowedRewardShare: 5,
+        maxAllowedRewardShare: 55.5,
         ipIds: [ipId],
         licenseData: {
           licenseTermsId,
@@ -264,7 +263,7 @@ describe("Group Functions", () => {
         const result = await client.groupClient.addIpsToGroup({
           groupIpId: groupId,
           ipIds: ipIds,
-          maxAllowedRewardSharePercentage: 5,
+          maxAllowedRewardSharePercentage: 55.55555555,
         });
         expect(result.txHash).to.be.a("string");
       });

packages/core-sdk/test/integration/ipAsset.test.ts

@@ -234,7 +234,6 @@ describe("IP Asset Functions", () => {
       const response = await client.ipAsset.registerDerivativeWithLicenseTokens({
         childIpId: ipId,
         licenseTokenIds: [mintLicenseTokensResult.licenseTokenIds![0]],
-        maxRts: 5 * 10 ** 6,
       });
       expect(response.txHash).to.be.a("string");
     });
@@ -537,7 +536,6 @@ describe("IP Asset Functions", () => {
       const result = await client.ipAsset.mintAndRegisterIpAndMakeDerivativeWithLicenseTokens({
         spgNftContract: nftContract,
         licenseTokenIds: [mintLicenseTokensResult.licenseTokenIds![0]],
-        maxRts: 5 * 10 ** 6,
         ipMetadata: {
           ipMetadataURI: "test-uri",
           ipMetadataHash: toHex("test-metadata-hash", { size: 32 }),
@@ -1116,7 +1114,7 @@ describe("IP Asset Functions", () => {
         await client.ipAsset.mintAndRegisterIpAndMakeDerivativeWithLicenseTokens({
           spgNftContract: nftContractWithMintingFee,
           licenseTokenIds: licenseTokenIds!,
-          maxRts: MAX_ROYALTY_TOKEN,
+          maxRts: 0,
           ipMetadata: {
             ipMetadataURI: "test",
             ipMetadataHash: zeroHash,
@@ -1603,15 +1601,12 @@ describe("IP Asset Functions", () => {
             childIpId: childIpId,
             parentIpIds: [parentIpId],
             licenseTermsIds: [noCommercialLicenseTermsId],
-            maxMintingFee: 0,
-            maxRts: 5 * 10 ** 6,
-            maxRevenueShare: 0,
           },
           {
             childIpId: childIpId2,
             parentIpIds: [parentIpId],
             licenseTermsIds: [noCommercialLicenseTermsId],
-            maxMintingFee: 0,
+            maxMintingFee: 10000000,
             maxRts: 5 * 10 ** 6,
             maxRevenueShare: 0,
           },
@@ -1875,7 +1870,7 @@ describe("IP Asset Functions", () => {
             })
           ).ipId!,
           licenseTokenIds: [mintLicenseTokensResult.licenseTokenIds![0]],
-          maxRts: 5 * 10 ** 6,
+          maxRts: 0,
         });
 
         const tokenId2 = await getTokenId();
@@ -3568,9 +3563,6 @@ describe("IP Asset Functions", () => {
           derivData: {
             parentIpIds: [parentIpId!],
             licenseTermsIds: [commercialRemixLicenseTermsId],
-            maxMintingFee: 10000n,
-            maxRts: 100,
-            maxRevenueShare: 100,
           },
           royaltyShares: [
             {
@@ -3620,6 +3612,7 @@ describe("IP Asset Functions", () => {
           nft: { type: "minted", nftContract: mockERC721, tokenId: tokenId! },
           licenseTokenIds: licenseTokenIds!,
           maxRts: 100,
+          maxMintingFee: 10000n,
         });
 
         expect(result.ipId).to.be.a("string");

packages/core-sdk/test/integration/license.test.ts

@@ -109,8 +109,6 @@ describe("License Functions", () => {
       const result = await client.license.mintLicenseTokens({
         licenseTermsId: licenseId,
         licensorIpId: ipId,
-        maxMintingFee: 1,
-        maxRevenueShare: 100,
       });
       expect(result.txHash).to.be.a("string");
       expect(result.licenseTokenIds).to.be.a("array");
@@ -134,8 +132,8 @@ describe("License Functions", () => {
       const result = await client.license.mintLicenseTokens({
         licenseTermsId: licenseId,
         licensorIpId: ipIdB,
-        maxMintingFee: 1,
-        maxRevenueShare: 100,
+        maxMintingFee: 10000000,
+        maxRevenueShare: 55.55555555,
       });
       expect(result.txHash).to.be.a("string");
       expect(result.licenseTokenIds).to.be.a("array");