add failure messages to backend + tauri (#1141)

Author: echelon

.sqlx/query-9b99ccd0baf9a4b74d8903f63e3a3dcf4c09b75cad978f0532388cbd743b7516.json

@@ -110,6 +110,9 @@ pub struct ListSessionStatusDetailsResponse {
   /// An enum the frontend can use to display localized/I18N error
   /// messages. These pertain to both transient and permanent failures.
   pub maybe_failure_category_updated: Option<FrontendFailureCategoryForApiClients>,
+  
+  /// User-facing failure messages
+  pub maybe_failure_message: Option<String>,
 
   /// This is an integer number between 0 and 100 (both inclusive) that
   /// reports the completeness.

…f96440e2bafd52032e07951272fb1ec78b1.json …0a7738ee3b3faa77c5281bc8e4af96159b9.json.sqlx/query-243afe0bc574f9f233c7797add9faf96440e2bafd52032e07951272fb1ec78b1.json renamed to .sqlx/query-a2c9e2f61eba666254f8432b3c50a0a7738ee3b3faa77c5281bc8e4af96159b9.json .sqlx/query-243afe0bc574f9f233c7797add9faf96440e2bafd52032e07951272fb1ec78b1.json renamed to .sqlx/query-a2c9e2f61eba666254f8432b3c50a0a7738ee3b3faa77c5281bc8e4af96159b9.json

@@ -10,6 +10,8 @@ use log::info;
 use sqlite_tasks::queries::task::Task;
 use sqlite_tasks::queries::update_task_status::{update_task_status, UpdateTaskArgs};
 use tauri::AppHandle;
+use enums::tauri::tasks::task_failure_type::TaskFailureType;
+use sqlite_tasks::queries::update_task_status_with_rich_failure::{update_task_status_with_rich_failure, UpdateTaskWithRichFailureArgs};
 
 pub async fn handle_failed_job(
   app_handle: &AppHandle,
@@ -19,10 +21,19 @@ pub async fn handle_failed_job(
 ) -> AnyhowResult<()> {
   info!("Marking storyteller job as failed: {:?}", task.id);
 
-  update_task_status(UpdateTaskArgs {
+  let maybe_failure_type = job.status
+      .maybe_failure_category_updated
+      .as_ref()
+      .map(|val| TaskFailureType::from_frontend_failure_category_for_api(val));
+  
+  let maybe_failure_message = job.status.maybe_failure_message.as_deref();
+
+  update_task_status_with_rich_failure(UpdateTaskWithRichFailureArgs {
     db: task_database.get_connection(),
     task_id: &task.id,
     status: TaskStatus::CompleteFailure,
+    maybe_failure_type,
+    maybe_failure_message,
   }).await?;
 
   let service = to_generation_service_provider(task.provider);

Cargo.lock

@@ -100,6 +100,7 @@ SELECT
     jobs.maybe_inference_args,
 
     jobs.frontend_failure_category as maybe_frontend_failure_category,
+    jobs.failure_reason,
 
     jobs.on_success_result_entity_type as maybe_result_entity_type,
     jobs.on_success_result_entity_token as maybe_result_entity_token,
@@ -255,6 +256,7 @@ fn raw_records_to_public_result(records: Vec<RawGenericInferenceJobStatus>) -> V
           maybe_assigned_cluster: record.maybe_assigned_cluster,
           maybe_first_started_at: record.maybe_first_started_at,
           maybe_frontend_failure_category: record.maybe_frontend_failure_category,
+          failure_reason: record.failure_reason,
           request_details: RequestDetails {
             maybe_product_category: record.product_category,
             inference_category: record.inference_category,
@@ -316,6 +318,7 @@ struct RawGenericInferenceJobStatus {
   pub maybe_assigned_cluster: Option<String>,
 
   pub maybe_frontend_failure_category: Option<FrontendFailureCategory>,
+  pub failure_reason: Option<String>,
 
   pub is_keepalive_required: i8,
 
@@ -369,6 +372,7 @@ impl FromRow<'_, MySqlRow> for RawGenericInferenceJobStatus {
       maybe_assigned_worker: row.try_get("maybe_assigned_worker")?,
       maybe_assigned_cluster: row.try_get("maybe_assigned_cluster")?,
       maybe_frontend_failure_category: row.try_get("maybe_frontend_failure_category")?,
+      failure_reason: row.try_get("failure_reason")?,
       is_keepalive_required: row.try_get("is_keepalive_required")?,
       maybe_first_started_at: row.try_get("maybe_first_started_at")?,
       maybe_successfully_completed_at: row.try_get("maybe_successfully_completed_at")?,

crates/api_clients/artcraft/artcraft_api_defs/src/jobs/list_session_jobs.rs

@@ -59,6 +59,7 @@ SELECT
     jobs.maybe_inference_args,
 
     jobs.frontend_failure_category as `maybe_frontend_failure_category: enums::by_table::generic_inference_jobs::frontend_failure_category::FrontendFailureCategory`,
+    jobs.failure_reason,
 
     jobs.on_success_result_entity_type as maybe_result_entity_type,
     jobs.on_success_result_entity_token as maybe_result_entity_token,
@@ -231,6 +232,7 @@ fn raw_record_to_public_result(record: RawGenericInferenceJobStatus) -> GenericI
     maybe_assigned_cluster: record.maybe_assigned_cluster,
     maybe_first_started_at: record.maybe_first_started_at,
     maybe_frontend_failure_category: record.maybe_frontend_failure_category,
+    failure_reason: record.failure_reason,
     request_details: RequestDetails {
       maybe_product_category: record.product_category,
       inference_category: record.inference_category,
@@ -290,6 +292,7 @@ struct RawGenericInferenceJobStatus {
   pub maybe_assigned_cluster: Option<String>,
 
   pub maybe_frontend_failure_category: Option<FrontendFailureCategory>,
+  pub failure_reason: Option<String>,
 
   pub is_keepalive_required: i8,
 

crates/desktop/artcraft/src/services/storyteller/threads/storyteller_task_polling_thread/handle_storyteller_failed_job.rs

@@ -25,6 +25,7 @@ pub struct GenericInferenceJobStatus {
   pub maybe_first_started_at: Option<DateTime<Utc>>,
 
   pub maybe_frontend_failure_category: Option<FrontendFailureCategory>,
+  pub failure_reason: Option<String>,
 
   pub request_details: RequestDetails,
   pub maybe_result_details: Option<ResultDetails>,

crates/schema/database/mysql_queries/src/queries/generic_inference/web/batch_get_inference_job_status.rs

@@ -166,6 +166,7 @@ SELECT
     jobs.maybe_inference_args,
 
     jobs.frontend_failure_category as maybe_frontend_failure_category,
+    jobs.failure_reason,
 
     jobs.on_success_result_entity_type as maybe_result_entity_type,
     jobs.on_success_result_entity_token as maybe_result_entity_token,
@@ -321,6 +322,7 @@ fn raw_records_to_public_result(records: Vec<RawGenericInferenceJobStatus>) -> V
           maybe_assigned_cluster: record.maybe_assigned_cluster,
           maybe_first_started_at: record.maybe_first_started_at,
           maybe_frontend_failure_category: record.maybe_frontend_failure_category,
+          failure_reason: record.failure_reason,
           request_details: RequestDetails {
             maybe_product_category: record.product_category,
             inference_category: record.inference_category,
@@ -382,6 +384,7 @@ struct RawGenericInferenceJobStatus {
   pub maybe_assigned_cluster: Option<String>,
 
   pub maybe_frontend_failure_category: Option<FrontendFailureCategory>,
+  pub failure_reason: Option<String>,
 
   pub is_keepalive_required: i8,
 
@@ -435,6 +438,7 @@ impl FromRow<'_, MySqlRow> for RawGenericInferenceJobStatus {
       maybe_assigned_worker: row.try_get("maybe_assigned_worker")?,
       maybe_assigned_cluster: row.try_get("maybe_assigned_cluster")?,
       maybe_frontend_failure_category: row.try_get("maybe_frontend_failure_category")?,
+      failure_reason: row.try_get("failure_reason")?,
       is_keepalive_required: row.try_get("is_keepalive_required")?,
       maybe_first_started_at: row.try_get("maybe_first_started_at")?,
       maybe_successfully_completed_at: row.try_get("maybe_successfully_completed_at")?,

crates/schema/database/mysql_queries/src/queries/generic_inference/web/get_inference_job_status.rs

@@ -9,4 +9,5 @@ pub mod nuke_all_tasks;
 pub mod task;
 pub mod update_successful_task_status_with_metadata;
 pub mod update_successful_task_status_with_metadata_by_provider;
-pub mod update_task_status;
+pub mod update_task_status;
+pub mod update_task_status_with_rich_failure;