grab bag of refactoring, cleanup, etc. (#1160)

- rename seedance2pro crate
- deprecate methods
- remove smtp client
- etc.

Author: echelon

Cargo.lock

@@ -17,7 +17,7 @@ members = [
   "crates/api_clients/openai_sora_client",
   "crates/api_clients/openart_client",
   "crates/api_clients/muapi_client",
-  "crates/api_clients/seedance2pro",
+  "crates/api_clients/seedance2pro_client",
   "crates/api_clients/runwayml_client",
   "crates/api_clients/thumbnail_generator",
   "crates/api_clients/world_labs_api",
@@ -252,7 +252,7 @@ muapi_client = { path = "crates/api_clients/muapi_client" }
 mysql_queries = { path = "crates/schema/database/mysql_queries" }
 openai_sora_client = { path = "crates/api_clients/openai_sora_client" }
 primitives = { path = "crates/lib/data/primitives" }
-seedance2pro = { path = "crates/api_clients/seedance2pro" }
+seedance2pro_client = { path = "crates/api_clients/seedance2pro_client" }
 shared_service_components = { path = "crates/lib/shared_service_components" }
 sqlite_tasks = { path = "crates/schema/database/sqlite_tasks" }
 subprocess_common = { path = "crates/lib/subprocess_common" }

Cargo.toml

@@ -20,7 +20,7 @@ artcraft_api_defs.workspace = true
 artcraft_client.workspace = true
 fal_client.workspace = true
 muapi_client.workspace = true
-seedance2pro.workspace = true
+seedance2pro_client.workspace = true
 tokens.workspace = true
 url_utils.workspace = true
 world_labs_api.workspace = true

crates/api_clients/artcraft/artcraft_router/Cargo.toml

@@ -1,4 +1,4 @@
-use seedance2pro::creds::seedance2pro_session::Seedance2ProSession;
+use seedance2pro_client::creds::seedance2pro_session::Seedance2ProSession;
 
 pub struct RouterSeedance2ProClient {
   pub(crate) session: Seedance2ProSession,

crates/api_clients/artcraft/artcraft_router/src/client/router_seedance2pro_client.rs

@@ -3,7 +3,7 @@ use std::fmt::{Display, Formatter};
 use artcraft_client::error::storyteller_error::StorytellerError;
 use fal_client::error::fal_error_plus::FalErrorPlus;
 use muapi_client::error::muapi_error::MuapiError;
-use seedance2pro::error::seedance2pro_error::Seedance2ProError;
+use seedance2pro_client::error::seedance2pro_error::Seedance2ProError;
 
 #[derive(Debug)]
 pub enum ProviderError {

crates/api_clients/artcraft/artcraft_router/src/errors/provider_error.rs

@@ -1,6 +1,6 @@
 use artcraft_api_defs::generate::video::multi_function::seedance_2p0_multi_function_video_gen::Seedance2p0BatchCount;
-use seedance2pro::creds::seedance2pro_session::Seedance2ProSession;
-use seedance2pro::requests::generate_video::generate_video::{BatchCount, GenerateVideoArgs, Resolution};
+use seedance2pro_client::creds::seedance2pro_session::Seedance2ProSession;
+use seedance2pro_client::requests::generate_video::generate_video::{BatchCount, GenerateVideoArgs, Resolution};
 
 use crate::generate::generate_video::plan::artcraft::plan_generate_video_artcraft_seedance2p0::PlanArtcraftSeedance2p0;
 use crate::generate::generate_video::video_generation_cost_estimate::VideoGenerationCostEstimate;

crates/api_clients/artcraft/artcraft_router/src/generate/generate_video/cost/artcraft/estimate_video_cost_artcraft_seedance2p0.rs

@@ -1,5 +1,5 @@
-use seedance2pro::creds::seedance2pro_session::Seedance2ProSession;
-use seedance2pro::requests::generate_video::generate_video::{GenerateVideoArgs, Resolution};
+use seedance2pro_client::creds::seedance2pro_session::Seedance2ProSession;
+use seedance2pro_client::requests::generate_video::generate_video::{GenerateVideoArgs, Resolution};
 
 use crate::generate::generate_video::plan::seedance2pro::plan_generate_video_seedance2pro_seedance2p0::PlanSeedance2proSeedance2p0;
 use crate::generate::generate_video::video_generation_cost_estimate::VideoGenerationCostEstimate;

crates/api_clients/artcraft/artcraft_router/src/generate/generate_video/cost/seedance2pro/estimate_video_cost_seedance2pro_seedance2p0.rs

@@ -6,13 +6,13 @@ use crate::generate::generate_video::generate_video_response::{
 };
 use crate::generate::generate_video::plan::seedance2pro::plan_generate_video_seedance2pro_seedance2p0::PlanSeedance2proSeedance2p0;
 use crate::utils::download_file::download_file;
-use seedance2pro::requests::generate_video::generate_video::{
+use seedance2pro_client::requests::generate_video::generate_video::{
   generate_video, GenerateVideoArgs,
 };
-use seedance2pro::requests::prepare_file_upload::prepare_file_upload::{
+use seedance2pro_client::requests::prepare_file_upload::prepare_file_upload::{
   prepare_file_upload, PrepareFileUploadArgs,
 };
-use seedance2pro::requests::upload_file::upload_file::{
+use seedance2pro_client::requests::upload_file::upload_file::{
   upload_file, UploadFileArgs,
 };
 use url_utils::extension::extract_extension_from_url::{
@@ -58,7 +58,7 @@ pub async fn execute_seedance2pro_seedance2p0(
 
 /// Downloads a file from a source URL and re-uploads it to seedance2pro CDN.
 async fn upload_to_seedance2pro(
-  session: &seedance2pro::creds::seedance2pro_session::Seedance2ProSession,
+  session: &seedance2pro_client::creds::seedance2pro_session::Seedance2ProSession,
   source_url: &str,
 ) -> Result<String, ArtcraftRouterError> {
   let extension = extract_extension_from_url_str(source_url, &ExtractExtensions::All)
@@ -85,7 +85,7 @@ async fn upload_to_seedance2pro(
 }
 
 async fn upload_optional_url(
-  session: &seedance2pro::creds::seedance2pro_session::Seedance2ProSession,
+  session: &seedance2pro_client::creds::seedance2pro_session::Seedance2ProSession,
   url: Option<&str>,
 ) -> Result<Option<String>, ArtcraftRouterError> {
   match url {
@@ -95,7 +95,7 @@ async fn upload_optional_url(
 }
 
 async fn upload_optional_url_list(
-  session: &seedance2pro::creds::seedance2pro_session::Seedance2ProSession,
+  session: &seedance2pro_client::creds::seedance2pro_session::Seedance2ProSession,
   urls: Option<&[String]>,
 ) -> Result<Option<Vec<String>>, ArtcraftRouterError> {
   match urls {

crates/api_clients/artcraft/artcraft_router/src/generate/generate_video/execute/seedance2pro/execute_seedance2pro_seedance2p0.rs

@@ -8,7 +8,7 @@ use crate::errors::artcraft_router_error::ArtcraftRouterError;
 use crate::errors::client_error::ClientError;
 use crate::generate::generate_video::generate_video_request::GenerateVideoRequest;
 use crate::generate::generate_video::video_generation_plan::VideoGenerationPlan;
-use seedance2pro::requests::generate_video::generate_video::{BatchCount, Resolution};
+use seedance2pro_client::requests::generate_video::generate_video::{BatchCount, Resolution};
 
 #[derive(Debug, Clone)]
 pub struct PlanSeedance2proSeedance2p0 {

crates/api_clients/artcraft/artcraft_router/src/generate/generate_video/plan/seedance2pro/plan_generate_video_seedance2pro_seedance2p0.rs

@@ -1,5 +1,5 @@
 [package]
-name = "seedance2pro"
+name = "seedance2pro_client"
 edition = "2024"
 version = "0.0.1"
 publish = false
@@ -8,7 +8,7 @@ publish = false
 normal = ["workspace-build-acceleration"]
 
 [lib]
-name = "seedance2pro"
+name = "seedance2pro_client"
 path = "src/lib.rs"
 
 [dependencies]