Merge pull request #141 from eraydin/dev

Minor consolidations, and .NET Core migration of NHibernate

Author: osoykan

build.cake

@@ -31,7 +31,7 @@ var testProjects = new List<Tuple<string, string[]>>
                     new Tuple<string, string[]>("Stove.Tests.SampleApplication", new[] { "net461" }),
                     new Tuple<string, string[]>("Stove.Dapper.Tests", new[] { "net461" }),
                     new Tuple<string, string[]>("Stove.Hangfire.Tests", new[] { "netcoreapp2.0" }),
-                    new Tuple<string, string[]>("Stove.NHibernate.Tests", new[] { "net461" }),
+                    new Tuple<string, string[]>("Stove.NHibernate.Tests", new[] { "netcoreapp2.0" }),
                     new Tuple<string, string[]>("Stove.EntityFrameworkCore.Tests", new[] { "netcoreapp2.0" }),
                     new Tuple<string, string[]>("Stove.Serilog.Tests", new[] { "netcoreapp2.0" })
                 };

src/Stove.EntityFrameworkCore/EntityFrameworkCore/StoveDbContext.cs

@@ -15,12 +15,10 @@
 using Microsoft.EntityFrameworkCore.ChangeTracking;
 using Microsoft.EntityFrameworkCore.Metadata;
 
-using Stove.Collections.Extensions;
 using Stove.Commands;
 using Stove.Domain.Entities;
 using Stove.Domain.Entities.Auditing;
 using Stove.Domain.Uow;
-using Stove.Events;
 using Stove.Events.Bus;
 using Stove.Events.Bus.Entities;
 using Stove.Extensions;

src/Stove.NHibernate/NHibernate/StoveNHibernateBootstrapper.cs

@@ -1,10 +1,8 @@
 using System;
 using System.Linq;
-
-using NHibernate.Util;
-
+                     
 using Stove.Bootstrapping;
-using Stove.Domain.Uow;
+using Stove.Extensions;
 using Stove.NHibernate.Configuration;
 using Stove.NHibernate.Interceptors;
 

src/Stove.NHibernate/Stove.NHibernate.csproj

@@ -7,7 +7,7 @@
     <RootNamespace>Stove</RootNamespace>
     <AssemblyName>Stove.NHibernate</AssemblyName>
     <PackageId>Stove.NHibernate</PackageId>
-    <PackageTags>.net;framework;boilerplate;nhibernate</PackageTags>
+    <PackageTags>.net;core;framework;boilerplate;nhibernate</PackageTags>
     <RootNamespace>Stove</RootNamespace>
     <Description>NHibernate Orm integration for Stove.</Description>
   </PropertyGroup>
@@ -24,11 +24,7 @@
 
   <ItemGroup>
     <ProjectReference Include="..\Stove\Stove.csproj" />
-  </ItemGroup>
-
-  <ItemGroup>
-    <Reference Include="System.Transactions" />
-  </ItemGroup>
+  </ItemGroup>   
 
   <ItemGroup>
     <None Include="bin\Release\netstandard2.0\Stove.NHibernate.pdb">

src/Stove.Redis/Redis/DefaultRedisCacheSerializer.cs

@@ -18,7 +18,7 @@ public class DefaultRedisCacheSerializer : IRedisCacheSerializer, ITransientDepe
         /// </summary>
         /// <param name="objbyte">String representation of the object from the Redis server.</param>
         /// <returns>Returns a newly constructed object.</returns>
-        /// <seealso cref="IRedisCacheSerializer.Serialize" />
+        /// <seealso cref="Serialize" />
         public virtual object Deserialize(RedisValue objbyte)
         {
             return JsonSerializationHelper.DeserializeWithType(objbyte);
@@ -30,7 +30,7 @@ public virtual object Deserialize(RedisValue objbyte)
         /// <param name="value">Instance to serialize.</param>
         /// <param name="type">Type of the object.</param>
         /// <returns>Returns a string representing the object instance that can be placed into the Redis cache.</returns>
-        /// <seealso cref="IRedisCacheSerializer.Deserialize" />
+        /// <seealso cref="Deserialize" />
         public virtual string Serialize(object value, Type type)
         {
             return JsonSerializationHelper.SerializeWithType(value, type);

src/Stove/BackgroundJobs/BackgroundJob.cs

@@ -30,7 +30,7 @@ public IUnitOfWorkManager UnitOfWorkManager
             {
                 if (_unitOfWorkManager == null)
                 {
-                    throw new StoveException("Must set UnitOfWorkManager before use it.");
+                    throw new StoveException($"Must set {nameof(UnitOfWorkManager)} before use it.");
                 }
 
                 return _unitOfWorkManager;

…ove/BackgroundJobs/ISceduleJobManager.cs …ve/BackgroundJobs/IScheduleJobManager.cssrc/Stove/BackgroundJobs/ISceduleJobManager.cs renamed to src/Stove/BackgroundJobs/IScheduleJobManager.cs src/Stove/BackgroundJobs/ISceduleJobManager.cs renamed to src/Stove/BackgroundJobs/IScheduleJobManager.cs

@@ -1,4 +1,5 @@
 using System.Collections.Generic;
+using System.Linq;
 
 namespace Stove.Events.Bus.Entities
 {
@@ -13,7 +14,7 @@ public AggregateChangeReport()
 
         public bool IsEmpty()
         {
-            return DomainEvents.Count <= 0;
+            return !DomainEvents.Any();
         }
 
         public override string ToString()

src/Stove/Events/Bus/Entities/AggregateChangeReport.cs

@@ -1,11 +1,10 @@
 using System;
+using System.Collections.Generic;
 using System.Linq;
 using System.Reflection;
 
 using JetBrains.Annotations;
 
-using Stove.Domain.Uow;
-
 namespace Stove.Reflection.Extensions
 {
     public static class MemberInfoExtensions
@@ -26,13 +25,13 @@ public static TAttribute GetSingleAttributeOrNull<TAttribute>(this MemberInfo me
 		        throw new ArgumentNullException(nameof(memberInfo));
 	        }
 
-	        var attrs = memberInfo.GetCustomAttributes(typeof(TAttribute), inherit).ToList();
-	        if (attrs.Count > 0)
+	        List<object> attrs = memberInfo.GetCustomAttributes(typeof(TAttribute), inherit).ToList();
+	        if (attrs.Any())
 	        {
 		        return (TAttribute)attrs[0];
 	        }
 
-	        return default(TAttribute);
+	        return default;
 		}
 
         [CanBeNull]

src/Stove/Reflection/Extensions/MemberInfoExtensions.cs

@@ -1,6 +1,6 @@
 using System;
 
-using HibernatingRhinos.Profiler.Appender.EntityFramework;
+// using HibernatingRhinos.Profiler.Appender.EntityFramework;
 
 using Microsoft.Owin.Hosting;