Format CFBundleShortVersionString to spec

According to Apple:
> The release version number is a string composed of three period-separated integers.

This change makes an attempt to pull out a string that is valid for CFBundleShortVersionString from the input, returning the input if no matches are found

Author: DMcNamara

index.js

@@ -95,6 +95,20 @@ function getNewVersionCode(programOpts, versionCode, versionName, resetBuild) {
 	return versionCode ? versionCode + 1 : 1;
 }
 
+/**
+ * CFBundleShortVersionString must be a string composed of three period-separated integers.
+ * @private
+ * @param {String} versionName The full version string
+ * @return {String} e.g. returns '1.2.3' for given '1.2.3-beta.1'. Returns `versionName` if no match is found.
+ */
+function getCFBundleShortVersionString(versionName) {
+	const match =
+		versionName && typeof versionName === "string"
+			? versionName.match(/\d*\.\d*.\d*/g)
+			: [];
+	return match && match[0] ? match[0] : versionName;
+}
+
 /**
  * Determines whether the project is an Expo app or a plain React Native app
  * @private
@@ -428,7 +442,9 @@ function version(program, projectPath) {
 									json,
 									!programOpts.incrementBuild
 										? {
-												CFBundleShortVersionString: appPkg.version
+												CFBundleShortVersionString: getCFBundleShortVersionString(
+													appPkg.version
+												)
 										  }
 										: {},
 									!programOpts.neverIncrementBuild
@@ -607,6 +623,7 @@ function version(program, projectPath) {
 }
 
 module.exports = {
+	getCFBundleShortVersionString: getCFBundleShortVersionString,
 	getDefaults: getDefaults,
 	getPlistFilenames: getPlistFilenames,
 	isExpoProject: isExpoProject,

test/shortBundleVerions.js

@@ -0,0 +1,50 @@
+import { getCFBundleShortVersionString } from '../';
+import test from "ava";
+
+test(
+	"CFBundleShortVersionString basic",
+	t => {
+		const v = getCFBundleShortVersionString('1.2.3');
+		t.is(v, '1.2.3');
+	}
+);
+
+test(
+	"CFBundleShortVersionString alpha",
+	t => {
+		const v = getCFBundleShortVersionString('1.2.3-alpha');
+		t.is(v, '1.2.3');
+	}
+);
+
+test(
+	"CFBundleShortVersionString alpha point",
+	t => {
+		const v = getCFBundleShortVersionString('1.2.3-alpha.0');
+		t.is(v, '1.2.3');
+	}
+);
+
+test(
+	"CFBundleShortVersionString dash number",
+	t => {
+		const v = getCFBundleShortVersionString('1.2.3-0');
+		t.is(v, '1.2.3');
+	}
+);
+
+test(
+	"CFBundleShortVersionString extra dot",
+	t => {
+		const v = getCFBundleShortVersionString('1.2.3.0');
+		t.is(v, '1.2.3');
+	}
+);
+
+test(
+	"CFBundleShortVersionString garbage in, garbage out",
+	t => {
+		const v = getCFBundleShortVersionString('garbage');
+		t.is(v, 'garbage');
+	}
+);