Skip to content

Commit 0408888

Browse files
committed
Remove FindBugs
1 parent 1a3dac2 commit 0408888

File tree

9 files changed

+3
-301
lines changed

9 files changed

+3
-301
lines changed

README.md

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Usage
1515

1616
[ ![Download](https://api.bintray.com/packages/stoyicker-org/android-check-2/org.stoyicker.android-check/images/download.svg) ](https://bintray.com/stoyicker-org/android-check-2/org.stoyicker.android-check/_latestVersion)
1717

18-
This plugin is available in [the Gradle Plugin Portal](https://plugins.gradle.org/plugin/org.stoyicker.android-check) and jCenter. It attaches itself to the `check` task if it finds it (that is, you don't use the `plugins` block and you apply either the application or library Android plugins first) - otherwise you'll need to execute the corresponding tasks manually when desired: `androidCheckstyle` for CheckStyle, `androidFindbugs` for FindBugs and `androidPmd` for PMD.
18+
This plugin is available in [the Gradle Plugin Portal](https://plugins.gradle.org/plugin/org.stoyicker.android-check) and jCenter. It attaches itself to the `check` task if it finds it (that is, you don't use the `plugins` block and you apply either the application or library Android plugins first) - otherwise you'll need to execute the corresponding tasks manually when desired: `androidCheckstyle` for CheckStyle, and `androidPmd` for PMD.
1919

2020
Configuration
2121
-------------
@@ -50,22 +50,9 @@ check {
5050
// Output file for HTML reports, default: new File(project.buildDir, 'outputs/checkstyle/checkstyle.html')
5151
reportHTML new File(project.buildDir, 'path/where/you/want/checkstyle.html')
5252
}
53-
// FindBugs configuration
54-
findbugs {
55-
// Same options as Checkstyle, except for a couple of defaults:
56-
57-
// Configuration file for CheckStyle, default: <project_path>/config/findbugs.xml, if non-existent then <project_path>/<module_path>/config/findbugs.xml, if non-existent then plugin/src/main/resources/findbugs/conf-default.xml
58-
config 'path/to/findbugs.xml'
59-
60-
// Output file for XML reports, default: new File(project.buildDir, 'outputs/findbugs/findbugs.xml')
61-
reportXML new File(project.buildDir, 'path/where/you/want/findbugs.xml')
62-
63-
// Output file for HTML reports, default: new File(project.buildDir, 'outputs/findbugs/findbugs.html')
64-
reportHTML new File(project.buildDir, 'path/where/you/want/findbugs.html')
65-
}
6653
// PMD configuration
6754
pmd {
68-
// Same options as Checkstyle and FindBugs, except for a couple of defaults:
55+
// Same options as Checkstyle, except for a couple of defaults:
6956

7057
// Configuration file for CheckStyle, default: <project_path>/config/pmd.xml, if non-existent then <project_path>/<module_path>/config/pmd.xml, if non-existent then plugin/src/main/resources/pmd/conf-default.xml
7158
config 'path/to/pmd.xml'

plugin/build.gradle

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ dependencies {
99
// Android Lint also depends on guava, so don't bring it in twice
1010
exclude module: 'guava'
1111
}
12-
// FindBugs
13-
compile 'com.google.code.findbugs:findbugs:3.0.1'
1412
// PMD
1513
compile 'net.sourceforge.pmd:pmd-java:5.6.0'
1614
}
@@ -29,7 +27,7 @@ project.ext {
2927
version = "2.$masterCommitCount"
3028
website = 'https://github.com/stoyicker/android-check-2'
3129
scm = 'https://github.com/stoyicker/android-check-2'
32-
tags = ['android', 'plugin', 'check', 'checkstyle', 'findbugs', 'pmd']
30+
tags = ['android', 'plugin', 'check', 'checkstyle', 'pmd']
3331
pom = {
3432
licenses {
3533
license {

plugin/src/main/groovy/org/stoyicker/androidcheck/CheckExtension.groovy

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package org.stoyicker.androidcheck
22

33
import org.stoyicker.androidcheck.checkstyle.CheckstyleConfig
4-
import org.stoyicker.androidcheck.findbugs.FindbugsConfig
54
import org.stoyicker.androidcheck.pmd.PmdConfig
65
import org.gradle.api.Action
76
import org.gradle.api.Project
@@ -16,18 +15,13 @@ class CheckExtension {
1615

1716
void checkstyle(Action<CheckstyleConfig> action) { action.execute(checkstyle) }
1817

19-
FindbugsConfig findbugs
20-
21-
void findbugs(Action<FindbugsConfig> action) { action.execute(findbugs) }
22-
2318
PmdConfig pmd
2419

2520
void pmd(Action<PmdConfig> action) { action.execute(pmd) }
2621

2722
CheckExtension(Project project) {
2823
this.project = project
2924
this.checkstyle = new CheckstyleConfig(project)
30-
this.findbugs = new FindbugsConfig(project)
3125
this.pmd = new PmdConfig(project)
3226
}
3327

plugin/src/main/groovy/org/stoyicker/androidcheck/CheckPlugin.groovy

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package org.stoyicker.androidcheck
22

33
import org.stoyicker.androidcheck.checkstyle.CheckstyleCheck
4-
import org.stoyicker.androidcheck.findbugs.FindbugsCheck
54
import org.stoyicker.androidcheck.pmd.PmdCheck
65
import org.gradle.api.Plugin
76
import org.gradle.api.Project
@@ -13,7 +12,6 @@ class CheckPlugin implements Plugin<Project> {
1312
target.extensions.create(CheckExtension.NAME, CheckExtension, target)
1413

1514
new CheckstyleCheck().apply(target)
16-
new FindbugsCheck().apply(target)
1715
new PmdCheck().apply(target)
1816
}
1917

plugin/src/main/groovy/org/stoyicker/androidcheck/findbugs/FindbugsCheck.groovy

Lines changed: 0 additions & 76 deletions
This file was deleted.

plugin/src/main/groovy/org/stoyicker/androidcheck/findbugs/FindbugsConfig.groovy

Lines changed: 0 additions & 10 deletions
This file was deleted.

plugin/src/main/resources/findbugs/conf-default.xml

Lines changed: 0 additions & 33 deletions
This file was deleted.

plugin/src/main/resources/findbugs/findbugs.xsl

Lines changed: 0 additions & 152 deletions
This file was deleted.

sample/app/build.gradle

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,6 @@ dependencies {
3131
check {
3232
abortOnError false
3333

34-
findbugs {
35-
reportXML new File(project.buildDir, 'reports/findbugs/findbugs.xml')
36-
}
37-
3834
pmd {
3935
reportHTML new File(project.buildDir, 'reports/pmd/pmd.html')
4036
}

0 commit comments

Comments
 (0)