Skip to content

Commit 65ef8b8

Browse files
Merge pull request #169 from harry-kim/fix/in_bulk
Fix in_bulk to use field_name
2 parents c6c838c + ea34362 commit 65ef8b8

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

django_mock_queries/query.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ def exists(self):
114114
def in_bulk(self, id_list=None, *, field_name='pk'):
115115
result = {}
116116
for model in self.items:
117-
if id_list is None or model.pk in id_list:
117+
if id_list is None or getattr(model, field_name) in id_list:
118118
result[getattr(model, field_name)] = model
119119
return result
120120

tests/test_query.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1024,7 +1024,7 @@ def test_in_bulk(self):
10241024
qs = MockSet(golf, polo, kia)
10251025

10261026
self.assertEqual(qs.in_bulk(), {1: golf, 2: polo, 4: kia})
1027-
self.assertEqual(qs.in_bulk(id_list=[4], field_name='model'), {'kia': kia})
1027+
self.assertEqual(qs.in_bulk(id_list=['kia'], field_name='model'), {'kia': kia})
10281028

10291029
def test_annotate(self):
10301030
qs = MockSet(CarVariation(color='green', car=Car(model='golf', id=1), id=1),

0 commit comments

Comments
 (0)