Fix HTML errors in JavaDocs

Author: str4d

src/net/i2p/crypto/eddsa/EdDSAEngine.java

@@ -435,7 +435,7 @@ protected void engineSetParameter(AlgorithmParameterSpec spec) throws InvalidAlg
     }
 
     /**
-     * @deprecated replaced with <a href="#engineSetParameter(java.security.spec.AlgorithmParameterSpec)">
+     * @deprecated
      */
     @Override
     protected void engineSetParameter(String param, Object value) {

src/net/i2p/crypto/eddsa/math/GroupElement.java

@@ -36,12 +36,13 @@ public class GroupElement implements Serializable {
 
     /**
      * Available representations for a group element.
-     * <p><ul>
+     * <ul>
      * <li>P2: Projective representation $(X:Y:Z)$ satisfying $x=X/Z, y=Y/Z$.
      * <li>P3: Extended projective representation $(X:Y:Z:T)$ satisfying $x=X/Z, y=Y/Z, XY=ZT$.
      * <li>P1P1: Completed representation $((X:Z), (Y:T))$ satisfying $x=X/Z, y=Y/T$.
      * <li>PRECOMP: Precomputed representation $(y+x, y-x, 2dxy)$.
      * <li>CACHED: Cached representation $(Y+X, Y-X, Z, 2dT)$
+     * </ul>
      */
     public enum Representation {
         /** Projective ($P^2$): $(X:Y:Z)$ satisfying $x=X/Z, y=Y/Z$ */
@@ -223,12 +224,13 @@ public GroupElement(
      * <p>
      * A point $(x,y)$ is encoded by storing $y$ in bit 0 to bit 254 and the sign of $x$ in bit 255.
      * $x$ is recovered in the following way:
-     * <p><ul>
+     * </p><ul>
      * <li>$x = sign(x) * \sqrt{(y^2 - 1) / (d * y^2 + 1)} = sign(x) * \sqrt{u / v}$ with $u = y^2 - 1$ and $v = d * y^2 + 1$.
      * <li>Setting $β = (u * v^3) * (u * v^7)^{((q - 5) / 8)}$ one has $β^2 = \pm(u / v)$.
      * <li>If $v * β = -u$ multiply $β$ with $i=\sqrt{-1}$.
      * <li>Set $x := β$.
      * <li>If $sign(x) \ne$ bit 255 of $s$ then negate $x$.
+     * </ul>
      *
      * @param curve The curve.
      * @param s The encoded point.
@@ -864,7 +866,7 @@ GroupElement select(final int pos, final int b) {
      * Constant time.
      * <p>
      * Preconditions: (TODO: Check this applies here)
-     *   $a[31] <= 127$
+     *   $a[31] \le 127$
      * @param a $= a[0]+256*a[1]+\dots+256^{31} a[31]$
      * @return the GroupElement
      */

src/net/i2p/crypto/eddsa/math/ed25519/Ed25519FieldElement.java

@@ -62,13 +62,14 @@ public boolean isNonZero() {
      * TODO-CR BR: $h$ is allocated via new, probably not a good idea. Do we need the copying into temp variables if we do that?
      * <p>
      * Preconditions:
-     * <p><ul>
+     * </p><ul>
      * <li>$|f|$ bounded by $1.1*2^{25},1.1*2^{24},1.1*2^{25},1.1*2^{24},$ etc.
      * <li>$|g|$ bounded by $1.1*2^{25},1.1*2^{24},1.1*2^{25},1.1*2^{24},$ etc.
      * </ul><p>
      * Postconditions:
-     * <p><ul>
+     * </p><ul>
      * <li>$|h|$ bounded by $1.1*2^{26},1.1*2^{25},1.1*2^{26},1.1*2^{25},$ etc.
+     * </ul>
      *
      * @param val The field element to add.
      * @return The field element this + val.
@@ -90,13 +91,14 @@ public FieldElement add(FieldElement val) {
      * TODO-CR BR: See above.
      * <p>
      * Preconditions:
-     * <p><ul>
+     * </p><ul>
      * <li>$|f|$ bounded by $1.1*2^{25},1.1*2^{24},1.1*2^{25},1.1*2^{24},$ etc.
      * <li>$|g|$ bounded by $1.1*2^{25},1.1*2^{24},1.1*2^{25},1.1*2^{24},$ etc.
      * </ul><p>
      * Postconditions:
-     * <p><ul>
+     * </p><ul>
      * <li>$|h|$ bounded by $1.1*2^{26},1.1*2^{25},1.1*2^{26},1.1*2^{25},$ etc.
+     * </ul>
      *
      * @param val The field element to subtract.
      * @return The field element this - val.
@@ -116,12 +118,13 @@ public FieldElement subtract(FieldElement val) {
      * TODO-CR BR: see above.
      * <p>
      * Preconditions:
-     * <p><ul>
+     * </p><ul>
      * <li>$|f|$ bounded by $1.1*2^{25},1.1*2^{24},1.1*2^{25},1.1*2^{24},$ etc.
      * </ul><p>
      * Postconditions:
-     * <p><ul>
+     * </p><ul>
      * <li>$|h|$ bounded by $1.1*2^{25},1.1*2^{24},1.1*2^{25},1.1*2^{24},$ etc.
+     * </ul>
      *
      * @return The field element (-1) * this.
      */
@@ -139,14 +142,14 @@ public FieldElement negate() {
      * Can overlap $h$ with $f$ or $g$.
      * <p>
      * Preconditions:
-     * <p><ul>
+     * </p><ul>
      * <li>$|f|$ bounded by
      * $1.65*2^{26},1.65*2^{25},1.65*2^{26},1.65*2^{25},$ etc.
      * <li>$|g|$ bounded by
      * $1.65*2^{26},1.65*2^{25},1.65*2^{26},1.65*2^{25},$ etc.
      * </ul><p>
      * Postconditions:
-     * <p><ul>
+     * </p><ul>
      * <li>$|h|$ bounded by
      * $1.01*2^{25},1.01*2^{24},1.01*2^{25},1.01*2^{24},$ etc.
      * </ul><p>
@@ -390,11 +393,11 @@ public FieldElement multiply(FieldElement val) {
      * Can overlap $h$ with $f$.
      * <p>
      * Preconditions:
-     * <p><ul>
+     * </p><ul>
      * <li>$|f|$ bounded by $1.65*2^{26},1.65*2^{25},1.65*2^{26},1.65*2^{25},$ etc.
      * </ul><p>
      * Postconditions:
-     * <p><ul>
+     * </p><ul>
      * <li>$|h|$ bounded by $1.01*2^{25},1.01*2^{24},1.01*2^{25},1.01*2^{24},$ etc.
      * </ul><p>
      * See {@link #multiply(FieldElement)} for discussion
@@ -546,11 +549,11 @@ public FieldElement square() {
      * Can overlap $h$ with $f$.
      * <p>
      * Preconditions:
-     * <p><ul>
+     * </p><ul>
      * <li>$|f|$ bounded by $1.65*2^{26},1.65*2^{25},1.65*2^{26},1.65*2^{25},$ etc.
      * </ul><p>
      * Postconditions:
-     * <p><ul>
+     * </p><ul>
      * <li>$|h|$ bounded by $1.01*2^{25},1.01*2^{24},1.01*2^{25},1.01*2^{24},$ etc.
      * </ul><p>
      * See {@link #multiply(FieldElement)} for discussion

src/net/i2p/crypto/eddsa/math/ed25519/Ed25519LittleEndianEncoding.java

@@ -26,15 +26,15 @@ public class Ed25519LittleEndianEncoding extends Encoding {
      * <li>Convert the field element to the 32 byte representation.
      * </ol><p>
      * The idea for the modulo $p$ reduction algorithm is as follows:
-     * <p>
+     * </p>
      * <h2>Assumption:</h2>
-     * <p><ul>
+     * <ul>
      * <li>$p = 2^{255} - 19$
      * <li>$h = h_0 + 2^{25} * h_1 + 2^{(26+25)} * h_2 + \dots + 2^{230} * h_9$ where $0 \le |h_i| \lt 2^{27}$ for all $i=0,\dots,9$.
      * <li>$h \cong r \mod p$, i.e. $h = r + q * p$ for some suitable $0 \le r \lt p$ and an integer $q$.
      * </ul><p>
      * Then $q = [2^{-255} * (h + 19 * 2^{-25} * h_9 + 1/2)]$ where $[x] = floor(x)$.
-     * <p>
+     * </p>
      * <h2>Proof:</h2>
      * <p>
      * We begin with some very raw estimation for the bounds of some expressions:
@@ -242,8 +242,9 @@ public FieldElement decode(byte[] in) {
      * Return false if $x$ is in $\{0,2,4,\dots,q-1\}$
      * <p>
      * Preconditions:
-     * <p><ul>
+     * </p><ul>
      * <li>$|x|$ bounded by $1.1*2^{26},1.1*2^{25},1.1*2^{26},1.1*2^{25}$, etc.
+     * </ul>
      *
      * @return true if $x$ is in $\{1,3,5,\dots,q-2\}$, false otherwise.
      */

src/net/i2p/crypto/eddsa/math/ed25519/Ed25519ScalarOps.java

@@ -327,7 +327,7 @@ public byte[] reduce(byte[] s) {
      * $(ab+c) \bmod q$
      * <p>
      * Input:
-     * <p><ul>
+     * </p><ul>
      * <li>$a[0]+256*a[1]+\dots+256^{31}*a[31] = a$
      * <li>$b[0]+256*b[1]+\dots+256^{31}*b[31] = b$
      * <li>$c[0]+256*c[1]+\dots+256^{31}*c[31] = c$