Skip to content

Commit d3d4ff0

Browse files
committed
Replaced the hex bytes comparison with Arrays.equals(). Deleted the now useless TestUtils.java.
1 parent be161ee commit d3d4ff0

File tree

2 files changed

+6
-24
lines changed

2 files changed

+6
-24
lines changed

src/net/i2p/crypto/eddsa/math/ed25519/Ed25519FieldElement.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
package net.i2p.crypto.eddsa.math.ed25519;
22

3-
import net.i2p.crypto.eddsa.TestUtils;
3+
import java.util.Arrays;
4+
5+
import javax.xml.bind.DatatypeConverter;
6+
47
import net.i2p.crypto.eddsa.math.Field;
58
import net.i2p.crypto.eddsa.math.FieldElement;
69

@@ -959,13 +962,12 @@ public boolean equals(Object obj) {
959962
if (!(obj instanceof Ed25519FieldElement))
960963
return false;
961964
Ed25519FieldElement fe = (Ed25519FieldElement) obj;
962-
// XXX why does direct byte[] comparison fail?
963965
// TODO should this be constant time?
964-
return TestUtils.getHex(toByteArray()).equals(TestUtils.getHex(fe.toByteArray()));
966+
return Arrays.equals(toByteArray(), fe.toByteArray());
965967
}
966968

967969
@Override
968970
public String toString() {
969-
return "[Ed25519FieldElement val="+TestUtils.getHex(toByteArray())+"]";
971+
return "[Ed25519FieldElement val="+DatatypeConverter.printHexBinary(toByteArray())+"]";
970972
}
971973
}

test/net/i2p/crypto/eddsa/TestUtils.java

Lines changed: 0 additions & 20 deletions
This file was deleted.

0 commit comments

Comments
 (0)