Skip to content

Commit dc9f58f

Browse files
committed
Clarify that KeyPairGenerator takes a keysize, not strength
Ed25519 has nominal strength of 128 bits. Ref: https://tools.ietf.org/html/draft-irtf-cfrg-eddsa-08#section-10.5
1 parent 3684cad commit dc9f58f

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/net/i2p/crypto/eddsa/KeyPairGenerator.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@
2727
import net.i2p.crypto.eddsa.spec.EdDSAPublicKeySpec;
2828

2929
/**
30-
* Default strength is 256
30+
* Default keysize is 256 (Ed25519)
3131
*/
3232
public final class KeyPairGenerator extends KeyPairGeneratorSpi {
33-
private static final int DEFAULT_STRENGTH = 256;
33+
private static final int DEFAULT_KEYSIZE = 256;
3434
private EdDSAParameterSpec edParams;
3535
private SecureRandom random;
3636
private boolean initialized;
@@ -40,11 +40,11 @@ public final class KeyPairGenerator extends KeyPairGeneratorSpi {
4040
static {
4141
edParameters = new Hashtable<Integer, AlgorithmParameterSpec>();
4242

43-
edParameters.put(Integer.valueOf(DEFAULT_STRENGTH), new EdDSAGenParameterSpec(EdDSANamedCurveTable.CURVE_ED25519_SHA512));
43+
edParameters.put(Integer.valueOf(DEFAULT_KEYSIZE), new EdDSAGenParameterSpec(EdDSANamedCurveTable.CURVE_ED25519_SHA512));
4444
}
4545

46-
public void initialize(int strength, SecureRandom random) {
47-
AlgorithmParameterSpec edParams = edParameters.get(Integer.valueOf(strength));
46+
public void initialize(int keysize, SecureRandom random) {
47+
AlgorithmParameterSpec edParams = edParameters.get(Integer.valueOf(keysize));
4848
if (edParams == null)
4949
throw new InvalidParameterException("unknown key type.");
5050
try {
@@ -69,7 +69,7 @@ public void initialize(AlgorithmParameterSpec params, SecureRandom random) throw
6969

7070
public KeyPair generateKeyPair() {
7171
if (!initialized)
72-
initialize(DEFAULT_STRENGTH, new SecureRandom());
72+
initialize(DEFAULT_KEYSIZE, new SecureRandom());
7373

7474
byte[] seed = new byte[edParams.getCurve().getField().getb()/8];
7575
random.nextBytes(seed);

0 commit comments

Comments
 (0)