Updating from Crinja 0.8.1 to 0.9.0, issue with passing decoded JSON to a template

[ConfusionUnknown]

Hi!
I've got a project i'm attempting to move to Crinja 0.9.0 from 0.8.1 (so that it's able to compile on the new crystal version), but I'm having trouble with passing data into templates

My project allows you to pass in user-defined JSON objects into templates, which i use the Crystal JSON module to do. It returns JSON::Any objects, which I then convert to a Hash(String, JSON::Any) and pass to the template.

This worked fine on Crinja 0.8.1, but now causes an error unfortunately.

- alice

[straight-shoota]

What does the error message say?
Also it would be helpful if you could provide some code that demonstrates your use case. It the original code is available, maybe you could provide a link? Otherwise, perhaps a reduced reproduction?

[ConfusionUnknown]

The error (and stack trace) is as follows:

Unhandled exception: type error: can't wrap JSON::Any in Crinja::Value (Exception)
  from /home/confused/Projects/basalt-ng/lib/crinja/src/runtime/value.cr:92:7 in 'value'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/runtime/value.cr:114:5 in 'new'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/runtime/value.cr:35:32 in 'dictionary'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/runtime/value.cr:64:17 in 'value'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/runtime/value.cr:114:5 in 'new'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/runtime/value.cr:54:29 in 'variables'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/runtime/context.cr:78:11 in 'merge!'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/environment.cr:174:7 in 'render'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/template.cr:54:7 in 'render'
  from /home/confused/Projects/basalt-ng/src/theme.cr:27:16 in 'render_post'
  from /home/confused/Projects/basalt-ng/src/build.cr:66:5 in '_build_post'
  from /home/confused/Projects/basalt-ng/src/build.cr:75:28 in '_build_posts'
  from /home/confused/Projects/basalt-ng/src/build.cr:24:5 in 'build_site'
  from /home/confused/Projects/basalt-ng/src/commands/build_command.cr:26:5 in 'build_command'
  from /home/confused/Projects/basalt-ng/src/main.cr:17:7 in '->'
  from /usr/lib/crystal/option_parser.cr:499:19 in 'handle_flag'
  from /usr/lib/crystal/option_parser.cr:406:21 in 'parse'
  from /usr/lib/crystal/option_parser.cr:118:5 in '__crystal_main'
  from /usr/lib/crystal/crystal/main.cr:129:5 in 'main_user_code'
  from /usr/lib/crystal/crystal/main.cr:115:7 in 'main'
  from /usr/lib/crystal/crystal/system/unix/main.cr:9:3 in 'main'
  from /lib64/libc.so.6 in '??'
  from /lib64/libc.so.6 in '__libc_start_main'
  from /home/confused/Projects/basalt-ng/bin/ssg in '_start'
  from ???

Pointing at line 27 in this file: https://codeberg.org/confusionunknown/basalt-ng/src/branch/main/src/theme.cr#L27
It's from passing @post.meta, which is a Hash(String,JSON::Any)

[straight-shoota]

I believe since #18 you need to explicitly include crinja/json.
IIRC the reason is to avoid pulling in json as a dependency unless you need it. But Crinja needs JSON anyway for the to_json filter, so this seems mute.

[ConfusionUnknown]

Thanks for looking into this

Unfortunately, adding require 'crinja/json' after line 2 in the previously linked file leads to another crinja error. It doesn't seem happy iterating over a list in the JSON from the template, which previously worked

Unhandled exception: JSON::Any is not iterable
template: /home/confused/Projects/website/theme/clouds/post_types/release/release.jinja:9:4 .. 12:0

  7 |           </audio>
  8 |           <div class="tracklist">
  9 |                   {% for track in ssg_post_meta.tracks %}
  X |    ^
 10 |                   <p>{{track.number}}. <a href="javascript:void(0);" onclick="playtrack({{track.number}})">{{track.name}}</a></p>
 11 |                   {% endfor %}
 12 |           </div>
 13 |   </div>
 14 | </div>
 (Crinja::TypeError)
  from /home/confused/Projects/basalt-ng/lib/crinja/src/runtime/value.cr:222:7 in 'raw_each'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/runtime/value.cr:231:18 in 'each'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/lib/util/for_loop.cr:70:11 in 'new'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/lib/tag/for.cr:32:16 in 'interpret_output'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/runtime/renderer.cr:90:5 in 'render'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/runtime/renderer.cr:70:19 in 'render'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/runtime/renderer.cr:64:5 in 'render'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/runtime/renderer.cr:50:14 in 'render'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/template.cr:69:5 in 'render'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/template.cr:61:7 in 'render'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/lib/tag/include.cr:46:7 in 'interpret'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/lib/tag.cr:35:7 in 'interpret_output'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/runtime/renderer.cr:90:5 in 'render'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/lib/tag/if.cr:29:9 in 'interpret'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/lib/tag.cr:35:7 in 'interpret_output'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/runtime/renderer.cr:90:5 in 'render'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/runtime/renderer.cr:70:19 in 'render'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/runtime/renderer.cr:64:5 in 'render'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/runtime/renderer.cr:50:14 in 'render'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/template.cr:69:5 in 'render'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/template.cr:61:7 in 'render'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/lib/tag/include.cr:46:7 in 'interpret'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/lib/tag.cr:35:7 in 'interpret_output'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/runtime/renderer.cr:90:5 in 'render'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/lib/tag/if.cr:29:9 in 'interpret'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/lib/tag.cr:35:7 in 'interpret_output'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/runtime/renderer.cr:90:5 in 'render'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/runtime/renderer.cr:70:19 in 'render'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/runtime/renderer.cr:64:5 in 'render'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/runtime/renderer.cr:50:14 in 'render'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/template.cr:69:5 in 'render'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/template.cr:61:7 in 'render'
  from /home/confused/Projects/basalt-ng/lib/crinja/src/template.cr:54:7 in 'render'
  from /home/confused/Projects/basalt-ng/src/theme.cr:28:16 in 'render_post'
  from /home/confused/Projects/basalt-ng/src/build.cr:66:5 in '_build_post'
  from /home/confused/Projects/basalt-ng/src/build.cr:75:28 in '_build_posts'
  from /home/confused/Projects/basalt-ng/src/build.cr:24:5 in 'build_site'
  from /home/confused/Projects/basalt-ng/src/commands/build_command.cr:26:5 in 'build_command'
  from /home/confused/Projects/basalt-ng/src/main.cr:17:7 in '->'
  from /usr/lib/crystal/option_parser.cr:499:19 in 'handle_flag'
  from /usr/lib/crystal/option_parser.cr:406:21 in 'parse'
  from /usr/lib/crystal/option_parser.cr:118:5 in '__crystal_main'
  from /usr/lib/crystal/crystal/main.cr:129:5 in 'main_user_code'
  from /usr/lib/crystal/crystal/main.cr:115:7 in 'main'
  from /usr/lib/crystal/crystal/system/unix/main.cr:9:3 in 'main'
  from /lib64/libc.so.6 in '??'
  from /lib64/libc.so.6 in '__libc_start_main'
  from /home/confused/Projects/basalt-ng/bin/ssg in '_start'
  from ???

The jinja file in question is here https://codeberg.org/confusionunknown/website/src/branch/main/theme/clouds/post_types/release/release.jinja