summarization manager - add summary prompt to messages #698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
pgrayy
commented
Aug 19, 2025
src/strands/agent/conversation_manager/summarizing_conversation_manager.py
Outdated
Show resolved
Hide resolved
src/strands/agent/conversation_manager/summarizing_conversation_manager.py
Outdated
Show resolved
Hide resolved
Unshure
reviewed
Aug 22, 2025
I did think about this yes and actually tested with it. There were 2 (minor) concerns I had though:
Again these are minor concerns and so I could get behind just switching the role type. It would certainly simplify the PR. Made the change. See latest revision. |
JackYPCOnline
previously approved these changes
Aug 22, 2025
Unshure
approved these changes
Aug 28, 2025
dbschmigelski
pushed a commit
to dbavro19/sdk-python
that referenced
this pull request
Aug 28, 2025
…s#698) * summarization manager - add summary prompt to messages * summarize conversation - assistant to user role * fix test * add period
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Certain models (e.g., nova) require the messages array to start with a user message. The summarization manager however adds its summarization as an assistant message to the beginning of the array and thus is incompatible with certain models. To fix, I am changing the role to user.
Related Issues
#611
Documentation PR
N/A
Type of Change
Bug fix
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepare: Updated existing unit testshatch test tests_integ/test_summarizing_conversation_manager_integration.py- Locally altered the tests to use the nova pro model to properly ensure fix works.
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.