fix: add helper to handle base64 conversion to raw bytes for boto3 converse_stream
#940
+119
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shabie
requested a deployment
to
manual-approval
GitHub Actions
Waiting
shabie
changed the title
converse_stream
|
@Unshure I think it is a simple fix. Could you kindly have a look? |
pgrayy
reviewed
Oct 8, 2025
| else: # "auto" | ||
| return any(model in self.config["model_id"] for model in _MODELS_INCLUDE_STATUS) | ||
|
|
||
| def _coerce_to_bytes(self, value: Any, *, expected_fmt: Optional[str] = None) -> bytes: |
There was a problem hiding this comment.
I'm not so sure this logic should exist in the BedrockModel provider. The expected type of ["source"]["bytes"] is bytes (src) and so users should be configuring this before passing the payload into Strands. Also, this would be a problem for other model providers as well.
I'm thinking that this logic should go into https://github.com/strands-agents/sdk-python/blob/main/src/strands/multiagent/a2a/executor.py if we are trying to resolve #850.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
document,image, andvideopayloads to raw bytes before sending them to Bedrock so base64 strings no longer trigger “detected filetype is PLAIN_TEXT”.document.sourceinput types and fail fast on plain text.Related Issues
Type of Change
Bug fix
Testing
hatch testChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.