[ROS-O] drastically simplify explicit c++11 check #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required to build on Ubuntu 22.04 and newer systems.
[#222, #223, #224] introduced the additional logic dropped here, where the last messages clearly describe that the os detection is not needed.
I would have just dropped the whole block, but as JSK's group is involved here and I know some people like to keep old ROS versions theoretically supported, I changed the check to only add c++11 explicitly back in kinetic (as
melodicalready defaults to 14).The whole change is needed because Ubuntu 22.04 onwards provide a log4cxx which requires c++17, breaking this assumption.