chore: backport of Psalm fix

Author: COil

bin/coverage-checker.php

@@ -39,10 +39,10 @@
     $checkedElements += (int) $metric['coveredelements'];
 }
 
-$coverage = round(($checkedElements / $totalElements) * 100, 2);
+$coverage = round(((float) $checkedElements / (float) $totalElements) * 100.0, 2);
 if ($coverage < $percentage) {
-    echo ' > Code coverage: '.$coverage.'%, which is below the accepted '.$percentage.'% ❌'.\PHP_EOL.\PHP_EOL;
+    echo sprintf(' > Code coverage: %s%%, which is below the accepted threshold: %s%% ❌', $coverage, $percentage).\PHP_EOL.\PHP_EOL;
     exit(1);
 }
 
-echo \PHP_EOL.' > Code coverage: '.$coverage.'% - OK! ✅'.\PHP_EOL.\PHP_EOL;
+echo \PHP_EOL.sprintf(' > Code coverage: %s%% - OK! ✅', $coverage).\PHP_EOL.\PHP_EOL;

src/Controller/FormAction.php

@@ -25,6 +25,7 @@ public function __invoke(Request $request): Response
         $dto = new RegisterFormDto();
         $form = $this->createForm(RegisterForm::class, $dto)->handleRequest($request);
         if ($form->isSubmitted() && $form->isValid()) {
+            /** @var RegisterFormDto $dto */
             // just for the example, the DTO has already been updated at this point
             $dto = $form->getData();
         }

src/Entity/User.php

@@ -18,7 +18,7 @@
 #[ORM\Entity(repositoryClass: UserRepository::class)]
 #[ORM\Table(name: '`user`')]
 #[ORM\HasLifecycleCallbacks]
-class User implements \Stringable, UserInterface, PasswordAuthenticatedUserInterface
+final class User implements \Stringable, UserInterface, PasswordAuthenticatedUserInterface
 {
     final public const string ROLE_USER = 'ROLE_USER';
 
@@ -61,6 +61,7 @@ public function getId(): int
         return $this->id;
     }
 
+    #[\Override]
     public function __toString(): string
     {
         return $this->getUserIdentifier().' ('.$this->getId().')';
@@ -82,6 +83,7 @@ public function __unserialize(array $data): void
         [$this->id, $this->username, $this->password, $this->email] = $data;
     }
 
+    #[\Override]
     public function getUserIdentifier(): string
     {
         if ($this->username === '') {
@@ -94,6 +96,7 @@ public function getUserIdentifier(): string
     /**
      * Returns the roles or permissions granted to the user for security.
      */
+    #[\Override]
     public function getRoles(): array
     {
         return [self::ROLE_USER];
@@ -114,6 +117,7 @@ public function setEmail(string $email): self
         return $this;
     }
 
+    #[\Override]
     public function getPassword(): string
     {
         return $this->password;

src/Factory/UserFactory.php

@@ -14,6 +14,7 @@
  */
 final class UserFactory extends PersistentObjectFactory
 {
+    #[\Override]
     public static function class(): string
     {
         return User::class;
@@ -22,6 +23,7 @@ public static function class(): string
     /**
      * @return array<string, mixed>
      */
+    #[\Override]
     protected function defaults(): array
     {
         return [

src/Form/Type/RegisterForm.php

@@ -23,6 +23,7 @@
  */
 final class RegisterForm extends AbstractType
 {
+    #[\Override]
     public function buildForm(FormBuilderInterface $builder, array $options): void
     {
         $builder
@@ -46,6 +47,7 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
     /**
      * @see https://www.strangebuzz.com/en/blog/disable-the-html5-validation-of-all-your-symfony-forms-with-a-feature-flag
      */
+    #[\Override]
     public function configureOptions(OptionsResolver $resolver): void
     {
         $resolver->setDefaults([

src/Repository/UserRepository.php

@@ -22,7 +22,7 @@
  *
  * @see https://github.com/symfony/demo/blob/main/src/Repository/UserRepository.php
  */
-class UserRepository extends ServiceEntityRepository
+final class UserRepository extends ServiceEntityRepository
 {
     public function __construct(ManagerRegistry $registry)
     {

src/Story/AppStory.php

@@ -14,6 +14,7 @@
 #[AsFixture(name: 'main')]
 final class AppStory extends Story
 {
+    #[\Override]
     public function build(): void
     {
         UserFactory::createMany(10);

src/Twig/Extension/EnvExtension.php

@@ -16,6 +16,7 @@ final class EnvExtension extends AbstractExtension implements GlobalsInterface
     /**
      * @return array<string,string>
      */
+    #[\Override]
     public function getGlobals(): array
     {
         return [

tests/Integration/Entity/UserTest.php

@@ -15,6 +15,7 @@ final class UserTest extends KernelTestCase
 
     public function testPersistNewUserSuccess(): void
     {
+        /** @var EntityManagerInterface $em */
         $em = self::getContainer()->get(EntityManagerInterface::class);
         $user = new User(
             email: 'test@example.com',

tests/Integration/Twig/Extension/RoutingExtensionTest.php

@@ -16,6 +16,7 @@ final class RoutingExtensionTest extends KernelTestCase
     public function testRoutingExtensionInvalidArgumentException(): void
     {
         self::bootKernel();
+        /** @var RoutingExtension $extension */
         $extension = self::getContainer()->get(RoutingExtension::class);
         $this->expectException(\InvalidArgumentException::class);
         $extension->getControllerFqcn('foo');