Refactor database plugin core and add comprehensive test suite

- Updated base plugin structure to use functional approach
- Added plugin test suite for consistent testing across database plugins
- Simplified plugin creation with standardized configuration
- Updated Vitest to latest version and configured test configuration
- Added test helpers and mock generators for database plugins

Author: Eventyret

package-lock.json

@@ -82,7 +82,7 @@
 		"tsup": "^8.0.1",
 		"tsx": "^4.7.0",
 		"typescript": "^5.3.3",
-		"vitest": "^1.1.0"
+		"vitest": "^1.6.1"
 	},
 	"peerDependencies": {
 		"react": "^18.2.0"

package.json

@@ -0,0 +1,47 @@
+import { describe, it, expect } from 'vitest';
+import { DatabasePluginConfig, DatabaseAnswers } from '../types';
+import { createDatabasePlugin } from '../base-plugin';
+
+describe('Base Database Plugin', () => {
+  const mockConfig = {
+    name: 'TestDB',
+    defaultPort: 1234,
+    containerName: 'test-container',
+    volumePath: '/data/test'
+  };
+
+  it('should create a plugin with basic configuration', () => {
+    const plugin = createDatabasePlugin(mockConfig);
+    expect(plugin).toBeDefined();
+    expect(plugin.name).toBe('TestDB');
+    expect(plugin.getDefaultPort()).toBe(1234);
+  });
+
+  it('should validate required config properties', () => {
+    const plugin = createDatabasePlugin(mockConfig);
+    const answers = {
+      database: 'test_db',
+      username: 'test_user',
+      password: 'test_pass',
+      port: '1234'
+    };
+    expect(plugin.validateConfig(answers)).toBe(true);
+  });
+
+  it('should handle template variables', () => {
+    const plugin = createDatabasePlugin(mockConfig);
+    const config = {
+      database: 'test_db',
+      username: 'test_user',
+      password: 'test_pass',
+      port: '1234'
+    };
+    const variables = plugin.getTemplateVariables(config);
+    expect(variables).toHaveProperty('database', 'test_db');
+  });
+
+  it('should validate connection string format', () => {
+    const plugin = createDatabasePlugin(mockConfig);
+    expect(plugin.validateConnectionString('invalid')).toBe(false);
+  });
+}); 

src/plugins/databases/core/__tests__/base-plugin.test.ts

@@ -0,0 +1,53 @@
+import { describe, it, expect } from 'vitest';
+
+export function createPluginTestSuite(pluginName: string, plugin: any) {
+  describe(`Database Plugin: ${pluginName}`, () => {
+    // Structure Tests
+    it('should have required plugin structure', () => {
+      expect(plugin).toBeDefined();
+      expect(plugin.name).toBeDefined();
+      expect(typeof plugin.getTemplateVariables).toBe('function');
+      expect(typeof plugin.validateConfig).toBe('function');
+    });
+
+    // Configuration Tests
+    it('should have valid default configuration', () => {
+      expect(plugin.defaultPort).toBeGreaterThan(0);
+      expect(plugin.containerName).toBeDefined();
+      expect(plugin.volumePath).toBeDefined();
+    });
+
+    it('should generate valid template variables', () => {
+      const config = {
+        database: 'test_db',
+        username: 'test_user',
+        password: 'test_pass',
+        port: plugin.defaultPort
+      };
+
+      const variables = plugin.getTemplateVariables(config);
+      expect(variables).toHaveProperty('database', 'test_db');
+      expect(variables).toHaveProperty('username', 'test_user');
+      expect(variables).toHaveProperty('password', 'test_pass');
+      expect(variables).toHaveProperty('port', plugin.defaultPort);
+    });
+
+    it('should properly validate configurations', () => {
+      const validConfig = {
+        database: 'test_db',
+        username: 'test_user',
+        password: 'test_pass',
+        port: '5432'
+      };
+
+      const invalidConfig = {
+        database: 'test_db',
+        // missing username and password
+        port: '5432'
+      };
+
+      expect(plugin.validateConfig(validConfig)).toBe(true);
+      expect(plugin.validateConfig(invalidConfig)).toBe(false);
+    });
+  });
+} 

src/plugins/databases/core/__tests__/plugin-test-suite.ts

@@ -0,0 +1,19 @@
+import { DatabasePluginConfig, DatabaseAnswers } from '../types';
+
+export function createMockAnswers(overrides: Partial<DatabaseAnswers> = {}): DatabaseAnswers {
+  return {
+    database: 'test_db',
+    username: 'test_user',
+    password: 'test_password',
+    port: '3306',
+    ...overrides
+  };
+}
+
+export function validatePluginStructure(plugin: any) {
+  expect(plugin).toHaveProperty('name');
+  expect(plugin).toHaveProperty('getDefaultPort');
+  expect(plugin).toHaveProperty('validateConfig');
+  expect(plugin).toHaveProperty('validateConnectionString');
+  expect(plugin).toHaveProperty('getTemplateVariables');
+} 

src/plugins/databases/core/__tests__/test-helpers.ts

@@ -3,12 +3,14 @@ import { generateSecurePassword } from '../../../utils/passwords';
 import { getDockerImageVersions } from '../../../utils/docker-versions';
 
 export interface DatabasePlugin {
-  config: DatabasePluginConfig;
-  getQuestions: () => Promise<Question[]>;
-  processAnswers: (answers: Record<string, any>) => DatabaseAnswers;
-  getTemplateVariables: (answers: DatabaseAnswers) => Record<string, any>;
-  validate: (answers: DatabaseAnswers) => boolean;
-  validateField: (field: string, value: any) => boolean;
+  name: string;
+  defaultPort: number;
+  containerName: string;
+  volumePath: string;
+  getDefaultPort(): number;
+  validateConfig(answers: any): boolean;
+  validateConnectionString(connectionString: string): boolean;
+  getTemplateVariables(config: any): Record<string, any>;
 }
 
 export function createDatabasePlugin(config: DatabasePluginConfig): DatabasePlugin {
@@ -157,11 +159,34 @@ export function createDatabasePlugin(config: DatabasePluginConfig): DatabasePlug
   }
 
   return {
-    config,
-    getQuestions,
-    processAnswers,
-    getTemplateVariables,
-    validate,
-    validateField
+    name: config.name,
+    defaultPort: config.defaultPort,
+    containerName: config.containerName,
+    volumePath: config.volumePath,
+
+    getDefaultPort() {
+      return this.defaultPort;
+    },
+
+    validateConfig(answers: any) {
+      const requiredFields = ['database', 'username', 'password', 'port'];
+      return requiredFields.every(field => answers[field]);
+    },
+
+    validateConnectionString(connectionString: string) {
+      // Basic connection string validation
+      // Should match format: protocol://username:password@hostname:port/database
+      const connectionStringPattern = /^[a-zA-Z]+:\/\/[^:]+:[^@]+@[^:]+:\d+\/\w+$/;
+      return connectionStringPattern.test(connectionString);
+    },
+
+    getTemplateVariables(config: any) {
+      return {
+        port: config.port || this.defaultPort,
+        database: config.database,
+        username: config.username,
+        password: config.password
+      };
+    }
   };
 } 

src/plugins/databases/core/base-plugin.ts

@@ -0,0 +1,5 @@
+import { describe } from 'vitest';
+import plugin from '../index';
+import { createPluginTestSuite } from '../../core/__tests__/plugin-test-suite';
+
+createPluginTestSuite('MariaDB', plugin); 

src/plugins/databases/mariadb/__tests__/index.test.ts

@@ -1,9 +1,8 @@
 import { createDatabasePlugin } from '../core/base-plugin';
-import { config } from './config';
-import { getTemplateVariables } from './template-variables';
 
-const plugin = createDatabasePlugin(config);
-
-plugin.getTemplateVariables = getTemplateVariables;
-
-export default plugin; 
+export default createDatabasePlugin({
+  name: 'MariaDB',
+  defaultPort: 3306,
+  containerName: 'mariadb',
+  volumePath: '/var/lib/mysql'
+}); 

src/plugins/databases/mariadb/index.ts

@@ -0,0 +1,5 @@
+import { describe } from 'vitest';
+import plugin from '../index';
+import { createPluginTestSuite } from '../../core/__tests__/plugin-test-suite';
+
+createPluginTestSuite('MySQL', plugin); 

src/plugins/databases/mysql/__tests__/index.test.ts

@@ -1,9 +1,24 @@
 import { createDatabasePlugin } from '../core/base-plugin';
 import { config } from './config';
-import { getTemplateVariables } from './template-variables';
 
-const plugin = createDatabasePlugin(config);
+function getTemplateVariables(config: any) {
+  return {
+    port: config.port || this.defaultPort,
+    database: config.database,
+    username: config.username,
+    password: config.password,
+    rootPassword: config.rootPassword || config.password
+  };
+}
 
+const plugin = createDatabasePlugin({
+  name: 'MySQL',
+  defaultPort: 3306,
+  containerName: 'mysql',
+  volumePath: '/var/lib/mysql'
+});
+
+// Override the template variables method
 plugin.getTemplateVariables = getTemplateVariables;
 
 export default plugin;