Abstract that class creation action

Signed-off-by: mulhern <[email protected]>

Author: mulkieran

src/stratis_cli/_actions/_crypt.py

@@ -36,6 +36,22 @@
 from ._utils import long_running_operation
 
 
+def _make_class(spec, class_name, *, methods=None, timeout=-1):
+    """
+    Make a class from spec, with only requested methods.
+    Interpret None as all methods.
+    """
+    new_spec = ET.Element(spec.tag, spec.attrib)
+    new_spec.extend(
+        [
+            child
+            for child in spec
+            if child.tag == "method" and methods is None or child.get("name") in methods
+        ]
+    )
+    return make_class(class_name, new_spec, timeout=timeout)
+
+
 class CryptActions:
     """
     Whole pool encryption actions.
@@ -54,15 +70,9 @@ def encrypt(namespace: Namespace):
         # pylint: disable=import-outside-toplevel
         from ._data import MOPool, ObjectManager, pool_spec, pools
 
-        spec = ET.Element(pool_spec.tag, pool_spec.attrib)
-        spec.extend(
-            [
-                child
-                for child in pool_spec
-                if child.tag == "method" and child.get("name") == "EncryptPool"
-            ]
+        Pool = _make_class(  # pylint: disable=invalid-name
+            pool_spec, "Pool", methods=["EncryptPool"], timeout=10
         )
-        Pool = make_class("Pool", spec, timeout=10)  # pylint: disable=invalid-name
 
         pool_id = PoolId.from_parser_namespace(namespace)
         assert pool_id is not None
@@ -124,15 +134,10 @@ def unencrypt(namespace: Namespace):
         # pylint: disable=import-outside-toplevel
         from ._data import MOPool, ObjectManager, pool_spec, pools
 
-        spec = ET.Element(pool_spec.tag, pool_spec.attrib)
-        spec.extend(
-            [
-                child
-                for child in pool_spec
-                if child.tag == "method" and child.get("name") == "DecryptPool"
-            ]
+        Pool = _make_class(  # pylint: disable=invalid-name
+            pool_spec, "Pool", methods=["DecryptPool"], timeout=10
         )
-        Pool = make_class("Pool", spec, timeout=10)  # pylint: disable=invalid-name
+
         pool_id = PoolId.from_parser_namespace(namespace)
         assert pool_id is not None
 
@@ -175,15 +180,9 @@ def reencrypt(namespace: Namespace):
         # pylint: disable=import-outside-toplevel
         from ._data import ObjectManager, pool_spec, pools
 
-        spec = ET.Element(pool_spec.tag, pool_spec.attrib)
-        spec.extend(
-            [
-                child
-                for child in pool_spec
-                if child.tag == "method" and child.get("name") == "ReencryptPool"
-            ]
+        Pool = _make_class(  # pylint: disable=invalid-name
+            pool_spec, "Pool", methods=["ReencryptPool"], timeout=10
         )
-        Pool = make_class("Pool", spec, timeout=10)  # pylint: disable=invalid-name
 
         pool_id = PoolId.from_parser_namespace(namespace)
         assert pool_id is not None