profiler: only convert non-float/int values to unix to avoid unnecessary strptime calls (they're expensive)

Author: AlyaGomaa

slips_files/common/slips_utils.py

@@ -448,16 +448,15 @@ def convert_to_datetime(self, ts):
             else datetime.strptime(ts, given_format)
         )
 
+    def is_unix_ts(self, time) -> bool:
+        return isinstance(time, (int, float))
+
     def get_time_format(self, time) -> Optional[str]:
         if self.is_datetime_obj(time):
             return "datetimeobj"
 
-        try:
-            # Try unix timestamp in seconds.
-            datetime.fromtimestamp(float(time))
+        if self.is_unix_ts(time):
             return "unixtimestamp"
-        except ValueError:
-            pass
 
         for time_format in self.time_formats:
             try:

slips_files/core/profiler_worker.py

@@ -135,12 +135,15 @@ def get_private_client_ips(
                 private_clients.append(ip)
         return private_clients
 
-    def convert_starttime_to_epoch(self, starttime) -> str:
+    def convert_starttime_to_unix_ts(self, starttime) -> str:
+        if utils.is_unix_ts(starttime):
+            return starttime
+
         try:
             return utils.convert_ts_format(starttime, "unixtimestamp")
         except ValueError:
             self.print(
-                f"We can not recognize time format of "
+                f"Slips can not recognize time format of "
                 f"flow.starttime: {starttime}",
                 0,
                 1,
@@ -537,7 +540,7 @@ def add_flow_to_profile(self, flow):
         self.print(f"Storing data in the profile: {profileid}", 3, 0)
 
         n = time.time()
-        flow.starttime = self.convert_starttime_to_epoch(flow.starttime)
+        flow.starttime = self.convert_starttime_to_unix_ts(flow.starttime)
         time_it_Took = time.time() - n
 
         self.log_time("convert_starttime_to_epoch", time_it_Took)

tests/test_profiler_worker.py

@@ -199,7 +199,7 @@ def test_convert_starttime_to_epoch():
     ) as mock_convert_ts_format:
         mock_convert_ts_format.return_value = 1680604800
 
-        converted = profiler.convert_starttime_to_epoch(starttime)
+        converted = profiler.convert_starttime_to_unix_ts(starttime)
 
         mock_convert_ts_format.assert_called_once_with(
             "2023-04-04 12:00:00", "unixtimestamp"
@@ -214,7 +214,7 @@ def test_convert_starttime_to_epoch_invalid_format(monkeypatch):
         "slips_files.core.profiler.utils.convert_ts_format",
         Mock(side_effect=ValueError),
     )
-    converted = profiler.convert_starttime_to_epoch(starttime)
+    converted = profiler.convert_starttime_to_unix_ts(starttime)
     assert converted == "not a real time"