optimize DefaultJobStore::mark_past_jobs_as_stale

plebhash · plebhash · commit 1d452c6158e2 · 2025-12-07T20:37:13.000+04:00
diff --git a/sv2/channels-sv2/src/server/jobs/job_store.rs b/sv2/channels-sv2/src/server/jobs/job_store.rs
@@ -150,12 +150,8 @@ impl<T: Job + Clone + Debug> JobStore<T> for DefaultJobStore<T> {
     }
 
     fn mark_past_jobs_as_stale(&mut self) {
-        // Mark all past jobs as stale, so that shares can be rejected with the appropriate error
-        // code
-        self.stale_jobs = self.past_jobs.clone();
-
-        // Clear past jobs, as we're no longer going to validate shares for them
-        self.past_jobs.clear();
+        // Transfer past jobs to stale jobs collection and reset past jobs to empty
+        self.stale_jobs = std::mem::take(&mut self.past_jobs);
     }
 
     fn get_future_job_id_from_template_id(&self, template_id: u64) -> Option<u32> {

Original file line number	Diff line number	Diff line change
`@@ -150,12 +150,8 @@ impl<T: Job + Clone + Debug> JobStore<T> for DefaultJobStore<T> {`
`150`	`150`	`}`
`151`	`151`
`152`	`152`	`fn mark_past_jobs_as_stale(&mut self) {`
`153`		`- // Mark all past jobs as stale, so that shares can be rejected with the appropriate error`
`154`		`- // code`
`155`		`- self.stale_jobs = self.past_jobs.clone();`
`156`		`-`
`157`		`- // Clear past jobs, as we're no longer going to validate shares for them`
`158`		`- self.past_jobs.clear();`
	`153`	`+ // Transfer past jobs to stale jobs collection and reset past jobs to empty`
	`154`	`+ self.stale_jobs = std::mem::take(&mut self.past_jobs);`
`159`	`155`	`}`
`160`	`156`
`161`	`157`	`fn get_future_job_id_from_template_id(&self, template_id: u64) -> Option<u32> {`