Merge pull request #2023 from Shourya742/2025-12-11-add-miri-workflow

Add miri workflow

Author: Shourya742

.github/workflows/miri.yaml

@@ -0,0 +1,27 @@
+name: Miri
+
+on:
+  pull_request:
+    branches:
+      - main
+
+jobs:
+  miri-sv2:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Install Rust nightly + Miri
+        uses: dtolnay/rust-toolchain@nightly
+        with:
+          components: miri
+
+      - name: Miri setup
+        run: cargo miri setup
+
+      - name: Run Miri for buffer-sv2
+        run: cargo miri test -p buffer_sv2
+
+      - name: Run Miri for noise-sv2
+        run: cargo miri test -p noise_sv2

sv2/buffer-sv2/src/buffer_pool/mod.rs

@@ -423,7 +423,7 @@ impl InnerMemory {
         shared_state: &mut SharedState,
         #[cfg(feature = "debug")] mode: u8,
     ) -> Slice {
-        let slice = &mut self.pool[self.raw_offset..self.raw_offset + self.raw_len];
+        let offset = unsafe { self.pool.as_mut_ptr().add(self.raw_offset) };
 
         let mut index: u8 = crate::slice::INGORE_INDEX;
 
@@ -440,14 +440,14 @@ impl InnerMemory {
             shared_state.toogle(index);
         }
 
-        let offset = slice.as_mut_ptr();
+        let len = self.raw_len;
 
         self.raw_offset += self.raw_len;
         self.raw_len = 0;
 
         Slice {
             offset,
-            len: slice.len(),
+            len,
             index,
             shared_state: shared_state.clone(),
             owned: None,

sv2/noise-sv2/src/handshake.rs

@@ -476,6 +476,7 @@ mod test {
 
     #[test]
     #[cfg(feature = "std")]
+    #[cfg_attr(miri, ignore)]
     fn test_ecdh() {
         let key_pair_1 = TestHandShake::generate_key();
         let key_pair_2 = TestHandShake::generate_key();
@@ -493,6 +494,7 @@ mod test {
     }
 
     #[test]
+    #[cfg_attr(miri, ignore)]
     fn test_ecdh_with_rng() {
         let key_pair_1 = TestHandShake::generate_key_with_rng(&mut rand::thread_rng());
         let key_pair_2 = TestHandShake::generate_key_with_rng(&mut rand::thread_rng());
@@ -534,6 +536,7 @@ mod test {
     }
 
     #[quickcheck_macros::quickcheck]
+    #[cfg_attr(miri, ignore)]
     fn test_ecdh_1(kp1: KeypairWrapper, kp2: KeypairWrapper) -> TestResult {
         let (kp1, kp2) = match (kp1.0, kp2.0) {
             (Some(kp1), Some(kp2)) => (kp1, kp2),

sv2/noise-sv2/src/test.rs

@@ -2,6 +2,7 @@ use crate::{handshake::HandshakeOp, initiator::Initiator, responder::Responder};
 
 #[test]
 #[cfg(feature = "std")]
+#[cfg_attr(miri, ignore)]
 fn test_1() {
     let key_pair = Responder::generate_key();
 
@@ -17,7 +18,9 @@ fn test_1() {
 
     assert!(message == "ciao".as_bytes().to_vec());
 }
+
 #[test]
+#[cfg_attr(miri, ignore)]
 fn test_1_with_rng() {
     let key_pair = Responder::generate_key_with_rng(&mut rand::thread_rng());