Add coinbase_witness to NewTemplate

[Sjors]

We should add a coinbase_witness field to the Sv2NewTemplate message rather than assume it to be 0x00...00.

Proposed Template Provider implementation: stratum-mining/sv2-tp#10

[TheBlueMatt]

Why does this need to be communicated to the mining logic? The mining logic should never change it and its committed to in the output the template distributor provides.

[plebhash]

Why does this need to be communicated to the mining logic? The mining logic should never change it and its committed to in the output the template distributor provides.

NewTemplate is a message under the Template Distribution Protocol, while your comment seems to assume it's under Mining Protocol?

[plebhash]

I'd like to point out that this issue is a duplicate of #156, and I think it's probably best to carry over the discussion there, given that it already provides rich context.

(for some reason, since my account suspension, the discussions I created are still not showing up on the main Discussion board of this repo... I have a support ticket opened with Github to try to solve that)

[TheBlueMatt]

NewTemplate is a message under the Template Distribution Protocol, while your comment seems to assume it's under Mining Protocol?

No, I was referring to the TDP. I guess the only reason to provide it would be so that it can be communicated to the pool as a part of the submission so that the pool can broadcast the block. If we rely on the local node to broadcast there'd be no reason for it but its useful not to, I suppose.

[plebhash]

closing in favor of #156

@TheBlueMatt please refer to that one, the discussion points have already been explored at length there.

[Sjors]

Ah I couldn't find #156, thanks for pointing to it.

[plebhash]

Ah I couldn't find #156, thanks for pointing to it.

yeah it really sucks that GitHub messed this up, hopefully my support ticket will get sorted and discussions I created will show up in the board again