Set nullable to false

Author: jkimbo

fastapi-sqlalchemy/alembic/versions/3a98bc1018d1_add_nullable_false.py

@@ -0,0 +1,74 @@
+"""Add nullable=False
+
+Revision ID: 3a98bc1018d1
+Revises: 3320c3c008d2
+Create Date: 2021-09-10 15:58:23.998900
+
+"""
+from alembic import op
+import sqlalchemy as sa
+
+
+# revision identifiers, used by Alembic.
+revision = '3a98bc1018d1'
+down_revision = '3320c3c008d2'
+branch_labels = None
+depends_on = None
+
+
+def upgrade():
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.alter_column('directors', 'name',
+               existing_type=sa.VARCHAR(),
+               nullable=False)
+    op.alter_column('movies', 'title',
+               existing_type=sa.VARCHAR(),
+               nullable=False)
+    op.alter_column('movies', 'imdb_id',
+               existing_type=sa.VARCHAR(),
+               nullable=False)
+    op.alter_column('movies', 'year',
+               existing_type=sa.INTEGER(),
+               nullable=False)
+    op.alter_column('movies', 'image_url',
+               existing_type=sa.VARCHAR(),
+               nullable=False)
+    op.alter_column('movies', 'imdb_rating',
+               existing_type=sa.FLOAT(),
+               nullable=False)
+    op.alter_column('movies', 'imdb_rating_count',
+               existing_type=sa.VARCHAR(),
+               nullable=False)
+    op.alter_column('movies', 'director_id',
+               existing_type=sa.INTEGER(),
+               nullable=False)
+    # ### end Alembic commands ###
+
+
+def downgrade():
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.alter_column('movies', 'director_id',
+               existing_type=sa.INTEGER(),
+               nullable=True)
+    op.alter_column('movies', 'imdb_rating_count',
+               existing_type=sa.VARCHAR(),
+               nullable=True)
+    op.alter_column('movies', 'imdb_rating',
+               existing_type=sa.FLOAT(),
+               nullable=True)
+    op.alter_column('movies', 'image_url',
+               existing_type=sa.VARCHAR(),
+               nullable=True)
+    op.alter_column('movies', 'year',
+               existing_type=sa.INTEGER(),
+               nullable=True)
+    op.alter_column('movies', 'imdb_id',
+               existing_type=sa.VARCHAR(),
+               nullable=True)
+    op.alter_column('movies', 'title',
+               existing_type=sa.VARCHAR(),
+               nullable=True)
+    op.alter_column('directors', 'name',
+               existing_type=sa.VARCHAR(),
+               nullable=True)
+    # ### end Alembic commands ###

fastapi-sqlalchemy/main/models.py

@@ -8,22 +8,22 @@
 class Director(Base):
     __tablename__ = "directors"
 
-    id: int = Column(Integer, primary_key=True, index=True)
-    name: str = Column(String, unique=True, index=True)
+    id: int = Column(Integer, primary_key=True, index=True, nullable=False)
+    name: str = Column(String, unique=True, index=True, nullable=False)
 
 
 class Movie(Base):
     __tablename__ = "movies"
 
-    id: int = Column(Integer, primary_key=True, index=True)
-    title: str = Column(String, unique=True)
-    imdb_id: str = Column(String, unique=True, index=True)
-    year: int = Column(Integer)
-    image_url: str = Column(String)
-    imdb_rating: float = Column(Float)
-    imdb_rating_count: str = Column(String)
+    id: int = Column(Integer, primary_key=True, index=True, nullable=False)
+    title: str = Column(String, unique=True, nullable=False)
+    imdb_id: str = Column(String, unique=True, index=True, nullable=False)
+    year: int = Column(Integer, nullable=False)
+    image_url: str = Column(String, nullable=False)
+    imdb_rating: float = Column(Float, nullable=False)
+    imdb_rating_count: str = Column(String, nullable=False)
 
-    director_id: int = Column(Integer, ForeignKey("directors.id"))
+    director_id: int = Column(Integer, ForeignKey("directors.id"), nullable=False)
     director: Director = relationship("Director")