Code review fixes and upgrade strawberry

Author: jkimbo

fastapi-sqlalchemy/alembic/versions/9bc8667ab6a6_add_initial_models.py

@@ -17,7 +17,6 @@
 
 
 def upgrade():
-    # ### commands auto generated by Alembic - please adjust! ###
     op.create_table(
         "directors",
         sa.Column("id", sa.Integer(), nullable=False),
@@ -45,15 +44,12 @@ def upgrade():
     )
     op.create_index(op.f("ix_movies_id"), "movies", ["id"], unique=False)
     op.create_index(op.f("ix_movies_imdb_id"), "movies", ["imdb_id"], unique=True)
-    # ### end Alembic commands ###
 
 
 def downgrade():
-    # ### commands auto generated by Alembic - please adjust! ###
     op.drop_index(op.f("ix_movies_imdb_id"), table_name="movies")
     op.drop_index(op.f("ix_movies_id"), table_name="movies")
     op.drop_table("movies")
     op.drop_index(op.f("ix_directors_name"), table_name="directors")
     op.drop_index(op.f("ix_directors_id"), table_name="directors")
     op.drop_table("directors")
-    # ### end Alembic commands ###

fastapi-sqlalchemy/alembic/versions/bea5e58f3328_add_data.py

@@ -23,7 +23,7 @@
 
 
 current_dir = Path(__file__).parent.resolve()
-data_file = current_dir.parent.parent.parent / Path("common-data") / Path("movies.json")
+data_file = current_dir.parent.parent.parent / "common-data" / "movies.json"
 
 
 def upgrade():

fastapi-sqlalchemy/api/schema.py

@@ -19,10 +19,6 @@ def on_request_end(self):
 
 @strawberry.type
 class Query:
-    @strawberry.field
-    def ping(self) -> str:
-        return "pong"
-
     @strawberry.field
     def top_rated_movies(self, info, limit: int = 250) -> List[Movie]:
         db = info.context["db"]

fastapi-sqlalchemy/poetry.lock

@@ -9,7 +9,7 @@ python = "^3.7"
 uvicorn = {extras = ["standard"], version = "^0.15.0"}
 SQLAlchemy = {extras = ["mypy"], version = "^1.4.23"}
 alembic = "^1.7.1"
-strawberry-graphql = {extras = ["asgi"], version = "^0.76.0"}
+strawberry-graphql = {extras = ["asgi"], version = "^0.77.0"}
 fastapi = "^0.68.1"