Make sure async session is still open when we call .all(). (#55)

Author: mattalbr

RELEASE.md

@@ -0,0 +1,3 @@
+Release type: patch
+
+Make sure async session is still open when we call .all()

src/strawberry_sqlalchemy_mapper/loader.py

@@ -45,13 +45,13 @@ def __init__(
                 "One of bind or async_bind_factory must be set for loader to function properly."
             )
 
-    async def _scalars(self, *args, **kwargs):
+    async def _scalars_all(self, *args, **kwargs):
         if self._async_bind_factory:
             async with self._async_bind_factory() as bind:
-                return await bind.scalars(*args, **kwargs)
+                return (await bind.scalars(*args, **kwargs)).all()
         else:
             assert self._bind is not None
-            return self._bind.scalars(*args, **kwargs)
+            return self._bind.scalars(*args, **kwargs).all()
 
     def loader_for(self, relationship: RelationshipProperty) -> DataLoader:
         """
@@ -70,7 +70,7 @@ async def load_fn(keys: List[Tuple]) -> List[Any]:
                 )
                 if relationship.order_by:
                     query = query.order_by(*relationship.order_by)
-                rows = (await self._scalars(query)).all()
+                rows = await self._scalars_all(query)
 
                 def group_by_remote_key(row: Any) -> Tuple:
                     return tuple(