fix: name conversion for lazy types (#3944)

* fix: name converter

* add RELEASE.md

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: commented test

* Update RELEASE.md

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Author: rcybulski1122012

RELEASE.md

@@ -0,0 +1,3 @@
+Release type: minor
+
+This release fixes NameConverter to properly handle lazy types.

strawberry/schema/name_converter.py

@@ -150,8 +150,9 @@ def get_name_from_type(self, type_: Union[StrawberryType, type]) -> str:
         type_ = eval_type(type_)
 
         if isinstance(type_, LazyType):
-            name = type_.type_name
-        elif isinstance(type_, EnumDefinition):
+            type_ = type_.resolve_type()
+
+        if isinstance(type_, EnumDefinition):
             name = type_.name
         elif isinstance(type_, StrawberryUnion):
             name = type_.graphql_name if type_.graphql_name else self.from_union(type_)

tests/objects/generics/test_names.py

@@ -41,9 +41,17 @@ class TypeB:
         ([TypeA], "TypeAExample"),
         ([CustomInt], "CustomIntExample"),
         ([TypeA, TypeB], "TypeATypeBExample"),
-        ([TypeA, LazyType["TypeB", "test_names"]], "TypeATypeBExample"),  # type: ignore
         (
-            [TypeA, Annotated["TypeB", strawberry.lazy("test_names")]],
+            [TypeA, LazyType["TypeB", "tests.objects.generics.test_names"]],
+            "TypeATypeBExample",
+        ),  # type: ignore
+        (
+            [
+                TypeA,
+                Annotated[
+                    "TypeB", strawberry.lazy("tests.objects.generics.test_names")
+                ],
+            ],
             "TypeATypeBExample",
         ),
     ],

tests/schema/test_name_converter.py

@@ -1,6 +1,6 @@
 import textwrap
 from enum import Enum
-from typing import Generic, Optional, TypeVar, Union
+from typing import Annotated, Generic, Optional, TypeVar, Union
 
 import strawberry
 from strawberry.directive import StrawberryDirective
@@ -78,6 +78,11 @@ class User:
     name: str
 
 
+@strawberry.type(name="MyType")
+class TypeWithDifferentNameThanClass:
+    name: str
+
+
 @strawberry.type
 class Error:
     message: str
@@ -115,6 +120,12 @@ def user(self, input: UserInput) -> Union[User, Error]:
 
     enum: MyEnum = MyEnum.A
     field: Optional[MyGeneric[str]] = None
+    field_with_lazy: MyGeneric[
+        Annotated[
+            "TypeWithDifferentNameThanClass",
+            strawberry.lazy("tests.schema.test_name_converter"),
+        ]
+    ] = None
 
     @strawberry.field
     def print(self, enum: MyEnum) -> str:
@@ -141,13 +152,22 @@ def test_name_converter():
       BX
     }
 
+    type MyTypeMyGenericXX {
+      valueX: MyTypeX!
+    }
+
+    type MyTypeX {
+      nameX: String!
+    }
+
     interface NodeXX {
       idX: ID!
     }
 
     type QueryX {
       enumX: MyEnumX!
       fieldX: StrMyGenericXX
+      fieldWithLazyX: MyTypeMyGenericXX!
       userX(inputX: UserInputX!): UserXErrorXX! @myDirectiveX(name: "my-directive")
       printX(enumX: MyEnumX!): String!
     }