Make pylance happy by adding missing assertions (#3933)

* Add missing data assertions

* Add missing skip reason

* Move assertings next to declarations

Author: DoctorJohn

tests/http/test_mutation.py

@@ -11,4 +11,5 @@ async def test_mutation(http_client: HttpClient):
     data = response.json["data"]
 
     assert response.status_code == 200
+    assert isinstance(data, dict)
     assert data["hello"] == "strawberry"

tests/http/test_query.py

@@ -20,9 +20,10 @@ async def test_graphql_query(method: Literal["get", "post"], http_client: HttpCl
         method=method,
         query="{ hello }",
     )
-    data = response.json["data"]
-
     assert response.status_code == 200
+
+    data = response.json["data"]
+    assert isinstance(data, dict)
     assert data["hello"] == "Hello world"
 
 
@@ -81,9 +82,10 @@ async def test_graphql_can_pass_variables(
         query="query hello($name: String!) { hello(name: $name) }",
         variables={"name": "Jake"},
     )
-    data = response.json["data"]
-
     assert response.status_code == 200
+
+    data = response.json["data"]
+    assert isinstance(data, dict)
     assert data["hello"] == "Hello Jake"
 
 
@@ -135,9 +137,10 @@ async def test_root_value(method: Literal["get", "post"], http_client: HttpClien
         method=method,
         query="{ rootName }",
     )
-    data = response.json["data"]
-
     assert response.status_code == 200
+
+    data = response.json["data"]
+    assert isinstance(data, dict)
     assert data["rootName"] == "Query"
 
 
@@ -268,13 +271,14 @@ async def test_query_context(method: Literal["get", "post"], http_client: HttpCl
         method=method,
         query="{ valueFromContext }",
     )
-    data = response.json["data"]
-
     assert response.status_code == 200
+
+    data = response.json["data"]
+    assert isinstance(data, dict)
     assert data["valueFromContext"] == "a value from context"
 
 
-@skip_if_gql_32
+@skip_if_gql_32("formatting is different in gql 3.2")
 @pytest.mark.parametrize("method", ["get", "post"])
 async def test_query_extensions(
     method: Literal["get", "post"], http_client: HttpClient
@@ -284,9 +288,10 @@ async def test_query_extensions(
         query='{ valueFromExtensions(key:"test") }',
         extensions={"test": "hello"},
     )
-    data = response.json["data"]
-
     assert response.status_code == 200
+
+    data = response.json["data"]
+    assert isinstance(data, dict)
     assert data["valueFromExtensions"] == "hello"
 
 

tests/http/test_upload.py

@@ -80,7 +80,7 @@ async def test_file_list_upload(enabled_http_client: HttpClient):
     )
 
     data = response.json["data"]
-
+    assert isinstance(data, dict)
     assert len(data["readFiles"]) == 2
     assert data["readFiles"][0] == "strawberry1"
     assert data["readFiles"][1] == "strawberry2"
@@ -98,6 +98,7 @@ async def test_nested_file_list(enabled_http_client: HttpClient):
     )
 
     data = response.json["data"]
+    assert isinstance(data, dict)
     assert len(data["readFolder"]) == 2
     assert data["readFolder"][0] == "strawberry1"
     assert data["readFolder"][1] == "strawberry2"
@@ -121,6 +122,7 @@ async def test_upload_single_and_list_file_together(enabled_http_client: HttpCli
     )
 
     data = response.json["data"]
+    assert isinstance(data, dict)
     assert len(data["readFiles"]) == 2
     assert data["readFiles"][0] == "strawberry1"
     assert data["readFiles"][1] == "strawberry2"