fix: prevent async iterable detection for sync execution in gql-core 3.3 (#4267)

* fix: prevent async iterable detection for sync execution in gql-core 3.3

* chore: bump graphql-core 3.3 version to 3.3.0a12 in CI

* fix: use tuples for AST node collections for gql-core 3.3 compat

graphql-core 3.3.0a12 requires tuples instead of lists for AST node
collection fields (e.g. ObjectValueNode.fields). Convert the list
comprehension in ast_from_leaf_type to a tuple.

* chore: add RELEASE.md for patch release

* chore: update RELEASE.md description

* chore: mention minimum gql-core 3.3.0a12 in RELEASE.md

* test: add regression test for execute_sync with __aiter__ objects

* test: improve docstring for __aiter__ sync execution test

Author: bellini666

.github/workflows/e2e-tests.yml

@@ -45,7 +45,7 @@ jobs:
       - name: Install Python dependencies
         run: |
           poetry install --extras cli
-          poetry run pip install graphql-core==3.3.0a9
+          poetry run pip install graphql-core==3.3.0a12
 
       - name: Start Strawberry server
         run: |

RELEASE.md

@@ -0,0 +1,10 @@
+Release type: patch
+
+Fix sync execution crash with graphql-core 3.3 where `execute_sync()` would return a coroutine
+instead of an `ExecutionResult`, causing `RuntimeError: There is no current event loop`,
+because graphql-core 3.3's `is_async_iterable` default treats objects with `__aiter__`
+(like Django QuerySets) as async iterables.
+
+Now passes `is_async_iterable=lambda _x: False` during sync execution to prevent this.
+
+Note: graphql-core >= 3.3.0a12 is now the minimum required version for the 3.3.x series.

noxfile.py

@@ -13,7 +13,7 @@
 
 GQL_CORE_VERSIONS = [
     "3.2.6",
-    "3.3.0a9",
+    "3.3.0a12",
 ]
 
 COMMON_PYTEST_OPTIONS = [

strawberry/printer/ast_from_value.py

@@ -70,13 +70,13 @@ def ast_from_leaf_type(serialized: object, type_: GraphQLInputType | None) -> Va
 
     if isinstance(serialized, dict):
         return ObjectValueNode(
-            fields=[
+            fields=tuple(
                 ObjectFieldNode(
                     name=NameNode(value=key),
                     value=ast_from_leaf_type(value, None),
                 )
                 for key, value in serialized.items()
-            ]
+            )
         )
 
     raise TypeError(

strawberry/schema/schema.py

@@ -95,6 +95,7 @@
     from strawberry.types.scalar import ScalarDefinition, ScalarWrapper
     from strawberry.types.union import StrawberryUnion
 
+
 SubscriptionResult: TypeAlias = AsyncGenerator[
     PreExecutionError | ExecutionResult, None
 ]
@@ -398,12 +399,18 @@ def create_extensions_runner(
         )
 
     def _get_custom_context_kwargs(
-        self, operation_extensions: dict[str, Any] | None = None
+        self,
+        operation_extensions: dict[str, Any] | None = None,
+        *,
+        sync: bool = False,
     ) -> dict[str, Any]:
         if not IS_GQL_33:
             return {}
 
-        return {"operation_extensions": operation_extensions}
+        kwargs: dict[str, Any] = {"operation_extensions": operation_extensions}
+        if sync:
+            kwargs["is_async_iterable"] = lambda _x: False
+        return kwargs
 
     def _get_middleware_manager(
         self, extensions: list[SchemaExtension], *, cached: bool = True
@@ -705,7 +712,9 @@ def execute_sync(
                     "Incremental execution is enabled but experimental_execute_incrementally is not available, "
                     "please install graphql-core>=3.3.0"
                 )
-        custom_context_kwargs = self._get_custom_context_kwargs(operation_extensions)
+        custom_context_kwargs = self._get_custom_context_kwargs(
+            operation_extensions, sync=True
+        )
 
         try:
             with extensions_runner.operation():

strawberry/utils/__init__.py

@@ -2,3 +2,9 @@
 
 IS_GQL_33 = version_info >= VersionInfo.from_str("3.3.0a0")
 IS_GQL_32 = not IS_GQL_33
+
+if IS_GQL_33 and version_info < VersionInfo.from_str("3.3.0a12"):
+    raise ImportError(
+        f"graphql-core {version_info} is not supported. "
+        "Please upgrade to graphql-core >= 3.3.0a12."
+    )

tests/schema/test_basic.py

@@ -578,3 +578,35 @@ class FooBar2:
             FooBar(foo=1)
         FooBar(bar=2)
         FooBar(foo=1, bar=2)
+
+
+def test_execute_sync_with_aiter_object():
+    """Sync execution works with objects that define __aiter__.
+
+    graphql-core 3.3's is_async_iterable default treats any object with
+    __aiter__ (e.g. Django QuerySets) as async, causing execute_sync to
+    return a coroutine instead of an ExecutionResult.
+    """
+
+    class FakeQuerySet:
+        def __aiter__(self):
+            raise NotImplementedError
+
+        def __iter__(self):
+            yield from [{"name": "Alice"}, {"name": "Bob"}]
+
+    @strawberry.type
+    class User:
+        name: str
+
+    @strawberry.type
+    class Query:
+        @strawberry.field
+        def users(self) -> list[User]:
+            return [User(name=u["name"]) for u in FakeQuerySet()]
+
+    schema = strawberry.Schema(query=Query)
+    result = schema.execute_sync("{ users { name } }")
+
+    assert not result.errors
+    assert result.data == {"users": [{"name": "Alice"}, {"name": "Bob"}]}