suite of pre-commit hooks for strawberry

[magicmark]

What are some rules we could provide as a provided set of a pre-commit hooks?

Going to use this discussion thread to jot down some things I've run into so far.

no-raw-dataclass

from dataclasses import dataclasss
import strawberry

@dataclass
@strawberry.type
class Foo:
    ...

(I see this one a ton)

[patrick91]

Maybe something like no-anonymous-unions?

import strawberry

@strawberry.type
class Foo:
    x: SomeType | SomeOtherType

[magicmark]

no-python-camel-case (can be used when auto camelCase is enabled)

@strawberry.type
class Foo:
    helloWorld: String

[magicmark]

ok here's a vibe-coded version of this with pygrep.... https://github.com/magicmark/strawberry-pre-commit-hooks/blob/101cf7eb656d9de9b5c9f8e3c8ec213ab7076520/.pre-commit-hooks.yaml kinda ugly and borderline unmaintanable imo tho

...but maybe it's ok as a black box as long as the tests are ok? a bit philosophical but what do we think?

Edit: actually disregard ^ this is garbage

Having more success with ast-grep but not with LLMs...

[magicmark]

gonna try with ast-grep