refactor: remove dissect change, moving to separate PR

strawgate · claude · strawgate · commit 6949cb9e2c90 · 2026-03-30T08:31:10.000-05:00
The dissect event.Clone() skip is moving to elastic#49777 which applies the same pattern more broadly across all action processors. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
diff --git a/libbeat/processors/dissect/processor.go b/libbeat/processors/dissect/processor.go
@@ -105,24 +105,18 @@ func (p *processor) Run(event *beat.Event) (*beat.Event, error) {
 		return event, err
 	}
 
-	// Clone for rollback is only needed when OverwriteKeys is false, since
-	// mapper can only fail when it encounters an existing key it cannot
-	// overwrite. When OverwriteKeys is true, mapper always succeeds.
-	var backup *beat.Event
-	if !p.config.OverwriteKeys {
-		backup = event.Clone()
-	}
+	backup := event.Clone()
 
 	if convertDataType {
 		event, err = p.mapper(event, mapInterfaceToMapStr(mc))
 	} else {
 		event, err = p.mapper(event, mapToMapStr(m))
 	}
-	if err != nil && backup != nil {
+	if err != nil {
 		return backup, err
 	}
 
-	return event, err
+	return event, nil
 }
 
 func (p *processor) mapper(event *beat.Event, m mapstr.M) (*beat.Event, error) {

Original file line number	Diff line number	Diff line change
`@@ -105,24 +105,18 @@ func (p processor) Run(event beat.Event) (*beat.Event, error) {`
`105`	`105`	`return event, err`
`106`	`106`	`}`
`107`	`107`
`108`		`- // Clone for rollback is only needed when OverwriteKeys is false, since`
`109`		`- // mapper can only fail when it encounters an existing key it cannot`
`110`		`- // overwrite. When OverwriteKeys is true, mapper always succeeds.`
`111`		`- var backup *beat.Event`
`112`		`- if !p.config.OverwriteKeys {`
`113`		`- backup = event.Clone()`
`114`		`- }`
	`108`	`+ backup := event.Clone()`
`115`	`109`
`116`	`110`	`if convertDataType {`
`117`	`111`	`event, err = p.mapper(event, mapInterfaceToMapStr(mc))`
`118`	`112`	`} else {`
`119`	`113`	`event, err = p.mapper(event, mapToMapStr(m))`
`120`	`114`	`}`
`121`		`- if err != nil && backup != nil {`
	`115`	`+ if err != nil {`
`122`	`116`	`return backup, err`
`123`	`117`	`}`
`124`	`118`
`125`		`- return event, err`
	`119`	`+ return event, nil`
`126`	`120`	`}`
`127`	`121`
`128`	`122`	`func (p processor) mapper(event beat.Event, m mapstr.M) (*beat.Event, error) {`