cgh: fix possible out of range on blockNumber

marcello33 · marcello33 · commit 32138d70ad37 · 2024-11-13T14:58:18.000+01:00
diff --git a/internal/cli/server/api_service.go b/internal/cli/server/api_service.go
@@ -118,6 +118,9 @@ func getRpcBlockNumberFromString(blockNumber string) (rpc.BlockNumber, error) {
 		if err != nil {
 			return rpc.BlockNumber(0), errors.New("invalid block number")
 		}
+		if blckNum > uint64(^uint32(0)) {
+			return rpc.BlockNumber(0), errors.New("block number out of range")
+		}
 		return rpc.BlockNumber(blckNum), nil
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -118,6 +118,9 @@ func getRpcBlockNumberFromString(blockNumber string) (rpc.BlockNumber, error) {`
`118`	`118`	`if err != nil {`
`119`	`119`	`return rpc.BlockNumber(0), errors.New("invalid block number")`
`120`	`120`	`}`
	`121`	`+ if blckNum > uint64(^uint32(0)) {`
	`122`	`+ return rpc.BlockNumber(0), errors.New("block number out of range")`
	`123`	`+ }`
`121`	`124`	`return rpc.BlockNumber(blckNum), nil`
`122`	`125`	`}`
`123`	`126`	`}`