Skip to content

Commit e771a07

Browse files
authored
Upgrade to Electron 43 (#25)
* fix set-output deprecation * update yarn.lock for electron43 * fix set-output deprecation; use GITHUB_OUTPUT
1 parent 0afdd81 commit e771a07

4 files changed

Lines changed: 518 additions & 588 deletions

File tree

.github/workflows/build.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,15 @@ env:
1919
BUILD_DIRECTORY: "build"
2020
DISTRIBUTE_DIRECTORY: "distribute"
2121
RELEASE_BUCKET: "obs-studio-deployment"
22-
ELECTRON_VERSION: "v29.4.3"
22+
ELECTRON_VERSION: "v43.2.0"
2323

2424
permissions:
2525
contents: read
2626

2727
jobs:
2828
build:
2929
name: 'Build a package'
30-
runs-on: windows-latest
30+
runs-on: windows-2022
3131
steps:
3232
- uses: actions/checkout@v3
3333
- name: Show GitHub context
@@ -36,12 +36,12 @@ jobs:
3636
run: echo "$GITHUB_CONTEXT"
3737
- name: Get the version
3838
id: get_version
39-
run: echo ::set-output name=VERSION::${GITHUB_REF/refs\/tags\//}
39+
run: echo "VERSION=${GITHUB_REF/refs\/tags\//}" >> "$GITHUB_OUTPUT"
4040
shell: bash
4141
- name: Install Node.js
42-
uses: actions/setup-node@v3
42+
uses: actions/setup-node@v4
4343
with:
44-
node-version: '16.x'
44+
node-version: '24.x'
4545
- name: Install dependencies
4646
run: yarn install --immutable --immutable-cache --check-cache
4747
- name: Add MSBuild to PATH
@@ -66,7 +66,7 @@ jobs:
6666
upload_debug_symbols:
6767
needs: build
6868
name: 'Upload debug symbols'
69-
runs-on: windows-latest
69+
runs-on: windows-2022
7070
if: startsWith(github.ref, 'refs/tags/')
7171
steps:
7272
- name: Get the version of aws cli
@@ -108,12 +108,12 @@ jobs:
108108
upload_release_package:
109109
needs: build
110110
name: 'Upload release package'
111-
runs-on: windows-latest
111+
runs-on: windows-2022
112112
if: startsWith(github.ref, 'refs/tags/')
113113
steps:
114114
- name: Get the version
115115
id: get_version
116-
run: echo ::set-output name=VERSION::${GITHUB_REF/refs\/tags\//}
116+
run: echo "VERSION=${GITHUB_REF/refs\/tags\//}" >> "$GITHUB_OUTPUT"
117117
shell: bash
118118
- name: Get build from cache
119119
id: cache-check

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_SOURCE_DIR}/cmake")
99

1010
SET(NODEJS_URL "https://artifacts.electronjs.org/headers/dist" CACHE STRING "Node.JS URL")
1111
SET(NODEJS_NAME "iojs" CACHE STRING "Node.JS Name")
12-
SET(NODEJS_VERSION "v29.4.3" CACHE STRING "Node.JS Version")
12+
SET(NODEJS_VERSION "v43.2.0" CACHE STRING "Node.JS Version")
1313

1414
include(NodeJS)
1515

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"main": "main.js",
55
"devDependencies": {
66
"colors": "^1.4.0",
7-
"electron": "29.4.3",
7+
"electron": "43.2.0",
88
"fs": "^0.0.1-security",
99
"path": "^0.12.7",
1010
"node-addon-api": "^7.1.1",

0 commit comments

Comments
 (0)