Merge pull request #1521 from streamlabs/fix_encoder_create_settings

summeroff · web-flow · commit 1ec7ec63ae53 · 2025-04-23T09:47:01.000-07:00
fix settings parsing in api v2 encoder create
diff --git a/obs-studio-client/source/video-encoder.cpp b/obs-studio-client/source/video-encoder.cpp
@@ -74,7 +74,7 @@ Napi::Value osn::VideoEncoder::Create(const Napi::CallbackInfo &info)
 	if (info.Length() > 2) {
 		Napi::Object json = info.Env().Global().Get("JSON").As<Napi::Object>();
 		Napi::Function stringify = json.Get("stringify").As<Napi::Function>();
-		Napi::String settingsObj = Napi::String::New(info.Env(), "");
+		Napi::Object settingsObj = info[2].ToObject();
 		settings = stringify.Call(json, {settingsObj}).As<Napi::String>().Utf8Value();
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ Napi::Value osn::VideoEncoder::Create(const Napi::CallbackInfo &info)`
`74`	`74`	`if (info.Length() > 2) {`
`75`	`75`	`Napi::Object json = info.Env().Global().Get("JSON").As<Napi::Object>();`
`76`	`76`	`Napi::Function stringify = json.Get("stringify").As<Napi::Function>();`
`77`		`- Napi::String settingsObj = Napi::String::New(info.Env(), "");`
	`77`	`+ Napi::Object settingsObj = info[2].ToObject();`
`78`	`78`	`settings = stringify.Call(json, {settingsObj}).As<Napi::String>().Utf8Value();`
`79`	`79`	`}`
`80`	`80`