Skip to content

Commit 2370eed

Browse files
Release a settings object
1 parent baddf13 commit 2370eed

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

obs-studio-server/source/nodeobs_settings.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -802,6 +802,7 @@ std::vector<SubCategory> OBS_settings::getStreamSettings(StreamServiceId service
802802
streamSettings.push_back(serviceConfiguration);
803803

804804
obs_properties_destroy(properties);
805+
obs_data_release(settings);
805806

806807
return streamSettings;
807808
}
@@ -844,9 +845,10 @@ bool OBS_settings::saveStreamSettings(std::vector<SubCategory> streamSettings, S
844845
break;
845846
}
846847
newserviceTypeValue = value;
848+
849+
//first setting is always stream type (if it's sent at all) - get default settings to be filled in
847850
settings = obs_service_defaults(newserviceTypeValue.c_str());
848851
if (currentStreamType.compare(newserviceTypeValue) != 0) {
849-
850852
if (newserviceTypeValue.compare("rtmp_common") == 0) {
851853
obs_data_set_string(settings, "streamType", "rtmp_common");
852854
obs_data_set_string(settings, "service", "Twitch");
@@ -888,7 +890,7 @@ bool OBS_settings::saveStreamSettings(std::vector<SubCategory> streamSettings, S
888890
}
889891

890892
obs_data_t *hotkeyData = obs_hotkeys_save_service(currentService);
891-
893+
892894
obs_service_t *newService = obs_service_create(newserviceTypeValue.c_str(), "default_service", settings, hotkeyData);
893895

894896
if (serviceChanged) {

0 commit comments

Comments
 (0)