Skip to content

Commit 7aef44a

Browse files
authored
Disable update replicas when autoscaling enabled (#1255)
<!-- ### Contribution Checklist - Name the pull request in the form "[charts/<chart-name>] Title of the pull request". Skip *[charts/<chart-name>]* if the PR doesn't change a specific chart. E.g. `[docs] Fix typo in README`. - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review. - Each pull request should address only one issue, not mix up code from multiple issues. - Each commit in the pull request has a meaningful commit message - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below. **(The sections below can be removed for hotfixes of typos)** --> *(If this PR fixes a github issue, please add `Fixes #<xyz>`.)* Fixes #<xyz> *(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)* Master Issue: #<xyz> ### Motivation *Explain here the context, and why you're making that change. What is the problem you're trying to solve.* ### Modifications *Describe the modifications you've done.* ### Verifying this change - [ ] Make sure that the change passes the CI checks. *(Please pick either of the following options)* This change is a trivial rework / code cleanup without any test coverage. *(or)* This change is already covered by existing tests, such as *(please describe tests)*. *(or)* This change added tests and can be verified as follows: *(example:)* - *Added integration tests for end-to-end deployment with large payloads (10MB)* - *Extended integration test for recovery after broker failure* ### Documentation Check the box below. Need to update docs? - [ ] `doc-required` (If you need help on updating docs, create a doc issue) - [ ] `no-need-doc` (Please explain why) - [ ] `doc` (If this PR contains doc changes)
1 parent 1cac9a2 commit 7aef44a

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

charts/sn-platform-slim/templates/broker/broker-cluster.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,9 @@ spec:
3232
{{- end }}
3333
zkServers: "{{ template "pulsar.zookeeper.connect" . }}{{ .Values.metadataPrefix }}"
3434
configurationStoreServers: "{{ template "pulsar.configurationStore.connect" . }}{{ .Values.metadataPrefix }}"
35+
{{- if not .Values.broker.autoScaling.enabled }}
3536
replicas: {{ .Values.broker.replicaCount }}
37+
{{- end }}
3638
{{- if not (and .Values.components.pulsar_coordinator .Values.images.coordinator) }}
3739
image: "{{ .Values.images.broker.repository }}:{{ .Values.images.broker.tag }}"
3840
{{- end }}

charts/sn-platform/templates/broker/broker-cluster.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,9 @@ spec:
3232
{{- end }}
3333
zkServers: "{{ template "pulsar.zookeeper.connect" . }}{{ .Values.metadataPrefix }}"
3434
configurationStoreServers: "{{ template "pulsar.configurationStore.connect" . }}{{ .Values.metadataPrefix }}"
35+
{{- if not .Values.broker.autoScaling.enabled }}
3536
replicas: {{ .Values.broker.replicaCount }}
37+
{{- end }}
3638
{{- if not (and .Values.components.pulsar_coordinator .Values.images.coordinator) }}
3739
image: "{{ .Values.images.broker.repository }}:{{ .Values.images.broker.tag }}"
3840
{{- end }}

0 commit comments

Comments
 (0)