Skip to content

Commit 9f56326

Browse files
committed
refactor(controller): simplify error wrapping in Reconcile
1 parent 882da8b commit 9f56326

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

controllers/serviceaccountbinding_controller.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ func (r *ServiceAccountBindingReconciler) Reconcile(ctx context.Context, req ctr
223223
errMsg := fmt.Sprintf("Failed to create remote ServiceAccountBinding for PoolMemberRef %d (%s): %v", i, remoteName, err)
224224
r.updateServiceAccountBindingStatus(ctx, binding, err, "CreateFailed", errMsg)
225225
allBindingsReady = false
226-
lastError = errors.Wrapf(err, errMsg)
226+
lastError = errors.Wrapf(err, "Failed to create remote ServiceAccountBinding for PoolMemberRef %d (%s)", i, remoteName)
227227
continue
228228
}
229229
logger.Info("Successfully created remote ServiceAccountBinding", "bindingName", remoteName, "poolMemberRef", poolMemberRef)
@@ -232,7 +232,7 @@ func (r *ServiceAccountBindingReconciler) Reconcile(ctx context.Context, req ctr
232232
errMsg := fmt.Sprintf("Failed to get remote ServiceAccountBinding for PoolMemberRef %d (%s): %v", i, remoteName, err)
233233
r.updateServiceAccountBindingStatus(ctx, binding, err, "GetFailed", errMsg)
234234
allBindingsReady = false
235-
lastError = errors.Wrapf(err, errMsg)
235+
lastError = errors.Wrapf(err, "Failed to get remote ServiceAccountBinding for PoolMemberRef %d (%s)", i, remoteName)
236236
continue
237237
}
238238
} else {

0 commit comments

Comments
 (0)