fix ci

Author: freeznet

pkg/admin/impl.go

@@ -620,10 +620,11 @@ func buildBacklogQuota(limitTime *rutils.Duration, limitSize *resource.Quantity,
 
 	backlogQuotaType := utils.DestinationStorage
 	if backlogQuotaTypeStr != nil {
-		backlogQuotaType, err = utils.ParseBacklogQuotaType(*backlogQuotaTypeStr)
+		parsedType, err := utils.ParseBacklogQuotaType(*backlogQuotaTypeStr)
 		if err != nil {
 			return nil, "", err
 		}
+		backlogQuotaType = parsedType
 	}
 
 	backlogQuota := utils.BacklogQuota{

tests/operator/resources_test.go

@@ -1774,24 +1774,15 @@ var _ = Describe("Resources", func() {
 				Expect(ns.Spec.Properties["team"]).Should(Equal("qa"))
 			})
 
-			It("should reconcile when backlog quota retention policy is unset", func() {
+			It("should fail when backlog quota retention policy is unset", func() {
 				ns := &v1alphav1.PulsarNamespace{}
 				tns := types.NamespacedName{Namespace: namespaceName, Name: storagePoliciesNamespaceName}
 				Expect(k8sClient.Get(ctx, tns, ns)).Should(Succeed())
 
 				ns.Spec.BacklogQuotaRetentionPolicy = nil
 
 				err := k8sClient.Update(ctx, ns)
-				Expect(err).Should(Succeed())
-			})
-
-			It("should be ready after removing backlog quota retention policy", func() {
-				Eventually(func() bool {
-					ns := &v1alphav1.PulsarNamespace{}
-					tns := types.NamespacedName{Namespace: namespaceName, Name: storagePoliciesNamespaceName}
-					Expect(k8sClient.Get(ctx, tns, ns)).Should(Succeed())
-					return v1alphav1.IsPulsarResourceReady(ns)
-				}, "30s", "100ms").Should(BeTrue())
+				Expect(err).ShouldNot(Succeed())
 			})
 
 			It("should allow clearing inactive topic policies and properties", func() {