Fix assertion on TopiCreateTimeStamp (#1952)

Author: RobertIndie

pkg/ctl/topic/stats_test.go

@@ -52,6 +52,8 @@ func TestGetStatsCmd(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
+	assert.Greaterf(t, stats.TopicCreationTimeStamp, int64(0), "TopicCreationTimeStamp should be greater than 0")
+	stats.TopicCreationTimeStamp = 0 // reset to zero for comparison
 
 	assert.Equal(t, defaultStats, stats)
 }
@@ -108,6 +110,7 @@ func TestGetPartitionedStatsCmd(t *testing.T) {
 	assert.Equal(t, "", stats.DeDuplicationStatus)
 	assert.Equal(t, 2, stats.Metadata.Partitions)
 	assert.Equal(t, 0, len(stats.Partitions))
+	assert.Greater(t, stats.TopicCreationTimeStamp, int64(0))
 }
 
 func TestGetPerPartitionedStatsCmd(t *testing.T) {
@@ -125,6 +128,15 @@ func TestGetPerPartitionedStatsCmd(t *testing.T) {
 		t.Fatal(err)
 	}
 
+	assert.Greater(t, stats.TopicCreationTimeStamp, int64(0))
+	stats.TopicCreationTimeStamp = 0
+	partitionKey := "persistent://public/default/test-topic-per-partitioned-stats-partition-0"
+	assert.Contains(t, stats.Partitions, partitionKey)
+	assert.Greaterf(t, stats.Partitions[partitionKey].TopicCreationTimeStamp, int64(0), "TopicCreationTimeStamp should be greater than 0")
+	v := stats.Partitions[partitionKey]
+	v.TopicCreationTimeStamp = 0
+	stats.Partitions[partitionKey] = v
+
 	defaultStats := utils.PartitionedTopicStats{
 		MsgRateIn:           0,
 		MsgRateOut:          0,
@@ -138,7 +150,7 @@ func TestGetPerPartitionedStatsCmd(t *testing.T) {
 		DeDuplicationStatus: "",
 		Metadata:            utils.PartitionedTopicMetadata{Partitions: 1},
 		Partitions: map[string]utils.TopicStats{
-			"persistent://public/default/test-topic-per-partitioned-stats-partition-0": {
+			partitionKey: {
 				MsgRateIn:           0,
 				MsgRateOut:          0,
 				MsgThroughputIn:     0,
@@ -195,6 +207,8 @@ func TestGetStatsWithPreciseBacklog(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
+	assert.Greaterf(t, stats.TopicCreationTimeStamp, int64(0), "TopicCreationTimeStamp should be greater than 0")
+	stats.TopicCreationTimeStamp = 0
 
 	assert.Equal(t, defaultStats, stats)
 }
@@ -213,6 +227,8 @@ func TestGetStatsWithoutSubscriptionBacklogSize(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
+	assert.Greaterf(t, stats.TopicCreationTimeStamp, int64(0), "TopicCreationTimeStamp should be greater than 0")
+	stats.TopicCreationTimeStamp = 0
 
 	assert.Equal(t, defaultStats, stats)
 }
@@ -231,6 +247,8 @@ func TestGetStatsWithEarliestTimeInBacklog(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
+	assert.Greaterf(t, stats.TopicCreationTimeStamp, int64(0), "TopicCreationTimeStamp should be greater than 0")
+	stats.TopicCreationTimeStamp = 0
 
 	assert.Equal(t, defaultStats, stats)
 }
@@ -249,6 +267,8 @@ func TestGetStatsWithMultipleNewFlags(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
+	assert.Greaterf(t, stats.TopicCreationTimeStamp, int64(0), "TopicCreationTimeStamp should be greater than 0")
+	stats.TopicCreationTimeStamp = 0
 
 	assert.Equal(t, defaultStats, stats)
 }
@@ -297,6 +317,15 @@ func TestGetPerPartitionStatsWithNewFlags(t *testing.T) {
 		t.Fatal(err)
 	}
 
+	assert.Greater(t, stats.TopicCreationTimeStamp, int64(0))
+	stats.TopicCreationTimeStamp = 0
+	partitionKey := "persistent://public/default/test-per-part-stats-new-flags-partition-0"
+	assert.Contains(t, stats.Partitions, partitionKey)
+	assert.Greaterf(t, stats.Partitions[partitionKey].TopicCreationTimeStamp, int64(0), "TopicCreationTimeStamp should be greater than 0")
+	v := stats.Partitions[partitionKey]
+	v.TopicCreationTimeStamp = 0
+	stats.Partitions[partitionKey] = v
+
 	defaultStats := utils.PartitionedTopicStats{
 		MsgRateIn:           0,
 		MsgRateOut:          0,
@@ -310,7 +339,7 @@ func TestGetPerPartitionStatsWithNewFlags(t *testing.T) {
 		DeDuplicationStatus: "",
 		Metadata:            utils.PartitionedTopicMetadata{Partitions: 1},
 		Partitions: map[string]utils.TopicStats{
-			"persistent://public/default/test-per-part-stats-new-flags-partition-0": {
+			partitionKey: {
 				MsgRateIn:           0,
 				MsgRateOut:          0,
 				MsgThroughputIn:     0,

scripts/run-integration-tests.sh

@@ -3,7 +3,7 @@ set -e
 
 readonly PROJECT_ROOT=`cd $(dirname $0)/..; pwd`
 readonly IMAGE_NAME=pulsarctl-test
-readonly PULSAR_DEFAULT_VERSION="4.0.4.3"
+readonly PULSAR_DEFAULT_VERSION="4.1.0.10"
 readonly PULSAR_VERSION=${PULSAR_VERSION:-${PULSAR_DEFAULT_VERSION}}
 
 docker build --build-arg PULSAR_VERSION=${PULSAR_VERSION} \