Skip to content

Commit d81a1d7

Browse files
committed
Fix lint and add lint command
1 parent b0a3be2 commit d81a1d7

File tree

4 files changed

+12
-3
lines changed

4 files changed

+12
-3
lines changed

Makefile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,3 +32,6 @@ pulsarctl:
3232
.PHONY: install
3333
install:
3434
go install github.com/streamnative/pulsarctl
35+
36+
lint-docker:
37+
docker run --rm -v $(shell pwd):/app -w /app golangci/golangci-lint:v2.7.2 golangci-lint run -v

pkg/ctl/functions/get_test.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,9 @@ func TestGetFunctionsWithFailure(t *testing.T) {
7070
_, err := os.Create(jarName)
7171
assert.Nil(t, err)
7272

73-
defer os.Remove(jarName)
73+
defer func(name string) {
74+
_ = os.Remove(name)
75+
}(jarName)
7476
args := []string{"create",
7577
"--tenant", "public",
7678
"--namespace", "default",

pkg/ctl/functions/putstate_test.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,9 @@ func TestByteValue(t *testing.T) {
159159
if err != nil {
160160
t.Fatal(err)
161161
}
162-
defer os.Remove(file.Name())
162+
defer func(name string) {
163+
_ = os.Remove(name)
164+
}(file.Name())
163165
if _, err := file.Write([]byte(buf)); err != nil {
164166
t.Fatal(err)
165167
}

pkg/ctl/functions/stop_test.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,9 @@ func TestStopFunctionsWithFailure(t *testing.T) {
7878
_, err := os.Create(jarName)
7979
assert.Nil(t, err)
8080

81-
defer os.Remove(jarName)
81+
defer func(name string) {
82+
_ = os.Remove(name)
83+
}(jarName)
8284
args := []string{"create",
8385
"--tenant", "public",
8486
"--namespace", "default",

0 commit comments

Comments
 (0)