fix lint

Author: freeznet

pkg/mcp/builders/config.go

@@ -19,10 +19,7 @@ package builders
 
 import (
 	"fmt"
-	"os"
 	"time"
-
-	"gopkg.in/yaml.v3"
 )
 
 // ToolsConfig represents the structure of the tools configuration file
@@ -38,35 +35,6 @@ type ToolConfig struct {
 	Options  map[string]interface{} `yaml:"options,omitempty"`
 }
 
-// LoadToolsConfig loads tool configuration from a file
-func LoadToolsConfig(filename string) (*ToolsConfig, error) {
-	data, err := os.ReadFile(filename)
-	if err != nil {
-		return nil, fmt.Errorf("failed to read config file %s: %w", filename, err)
-	}
-
-	var config ToolsConfig
-	if err := yaml.Unmarshal(data, &config); err != nil {
-		return nil, fmt.Errorf("failed to parse config file %s: %w", filename, err)
-	}
-
-	return &config, nil
-}
-
-// SaveToolsConfig saves tool configuration to a file
-func SaveToolsConfig(config *ToolsConfig, filename string) error {
-	data, err := yaml.Marshal(config)
-	if err != nil {
-		return fmt.Errorf("failed to marshal config: %w", err)
-	}
-
-	if err := os.WriteFile(filename, data, 0644); err != nil {
-		return fmt.Errorf("failed to write config file %s: %w", filename, err)
-	}
-
-	return nil
-}
-
 // ToToolBuildConfigs converts tool configuration to build configurations
 func (tc *ToolsConfig) ToToolBuildConfigs() map[string]ToolBuildConfig {
 	configs := make(map[string]ToolBuildConfig)

pkg/mcp/builders/config_test.go

@@ -18,8 +18,6 @@
 package builders
 
 import (
-	"os"
-	"path/filepath"
 	"testing"
 	"time"
 
@@ -170,61 +168,6 @@ func TestToolConfig(t *testing.T) {
 	})
 }
 
-func TestConfigFileOperations(t *testing.T) {
-	tempDir := t.TempDir()
-	configFile := filepath.Join(tempDir, "test_config.yaml")
-
-	t.Run("SaveAndLoadConfig", func(t *testing.T) {
-		originalConfig := &ToolsConfig{
-			Tools: map[string]ToolConfig{
-				"test_tool": {
-					Enabled:  true,
-					ReadOnly: false,
-					Features: []string{"feature1", "feature2"},
-					Options: map[string]interface{}{
-						"timeout":    "30s",
-						"maxRetries": 3,
-					},
-				},
-			},
-		}
-
-		// Save config
-		err := SaveToolsConfig(originalConfig, configFile)
-		require.NoError(t, err)
-
-		// Verify file exists
-		_, err = os.Stat(configFile)
-		assert.NoError(t, err)
-
-		// Load config
-		loadedConfig, err := LoadToolsConfig(configFile)
-		require.NoError(t, err)
-
-		// Verify content
-		assert.Equal(t, originalConfig.Tools["test_tool"].Enabled, loadedConfig.Tools["test_tool"].Enabled)
-		assert.Equal(t, originalConfig.Tools["test_tool"].ReadOnly, loadedConfig.Tools["test_tool"].ReadOnly)
-		assert.Equal(t, originalConfig.Tools["test_tool"].Features, loadedConfig.Tools["test_tool"].Features)
-		assert.Equal(t, originalConfig.Tools["test_tool"].Options, loadedConfig.Tools["test_tool"].Options)
-	})
-
-	t.Run("LoadNonexistentFile", func(t *testing.T) {
-		_, err := LoadToolsConfig("/nonexistent/config.yaml")
-		assert.Error(t, err)
-		assert.Contains(t, err.Error(), "failed to read config file")
-	})
-
-	t.Run("LoadInvalidYAML", func(t *testing.T) {
-		invalidFile := filepath.Join(tempDir, "invalid.yaml")
-		err := os.WriteFile(invalidFile, []byte("invalid: yaml: content: ["), 0644)
-		require.NoError(t, err)
-
-		_, err = LoadToolsConfig(invalidFile)
-		assert.Error(t, err)
-		assert.Contains(t, err.Error(), "failed to parse config file")
-	})
-}
-
 func TestConfigOptions(t *testing.T) {
 	t.Run("WithReadOnly", func(t *testing.T) {
 		config := NewToolBuildConfig(WithReadOnly(true))

pkg/mcp/builders/kafka/connect.go

@@ -33,6 +33,7 @@ import (
 
 // KafkaConnectToolBuilder implements the ToolBuilder interface for Kafka Connect
 // It provides functionality to build Kafka Connect administration tools
+// /nolint:revive
 type KafkaConnectToolBuilder struct {
 	*builders.BaseToolBuilder
 }
@@ -296,20 +297,6 @@ func (b *KafkaConnectToolBuilder) marshalResponse(data interface{}) (*mcp.CallTo
 	return mcp.NewToolResultText(string(jsonBytes)), nil
 }
 
-// getKafkaConnectClient retrieves the Kafka Connect client from context
-func (b *KafkaConnectToolBuilder) getKafkaConnectClient(ctx context.Context) (kafka.Connect, error) {
-	// Get Kafka session from context using the same key as in ctx.go
-	// We define the key locally to avoid circular import
-	type contextKey string
-	const kafkaSessionContextKey contextKey = "kafka_session"
-
-	session, ok := ctx.Value(kafkaSessionContextKey).(*kafka.Session)
-	if !ok || session == nil {
-		return nil, fmt.Errorf("Kafka session not found in context")
-	}
-	return session.GetConnectClient()
-}
-
 // Specific operation handler functions - migrated from original implementation
 
 // handleKafkaConnectClusterGet handles retrieving Kafka Connect cluster information

pkg/mcp/builders/kafka/consume.go

@@ -35,6 +35,7 @@ import (
 
 // KafkaConsumeToolBuilder implements the ToolBuilder interface for Kafka client consume operations
 // It provides functionality to build Kafka consumer tools
+// /nolint:revive
 type KafkaConsumeToolBuilder struct {
 	*builders.BaseToolBuilder
 	logger *logrus.Logger

pkg/mcp/builders/kafka/groups.go

@@ -31,6 +31,7 @@ import (
 )
 
 // KafkaGroupsToolBuilder implements the ToolBuilder interface for Kafka Consumer Groups
+// /nolint:revive
 type KafkaGroupsToolBuilder struct {
 	*builders.BaseToolBuilder
 }

pkg/mcp/builders/kafka/partitions.go

@@ -31,6 +31,7 @@ import (
 )
 
 // KafkaPartitionsToolBuilder implements the ToolBuilder interface for Kafka Partitions
+// /nolint:revive
 type KafkaPartitionsToolBuilder struct {
 	*builders.BaseToolBuilder
 }

pkg/mcp/builders/kafka/produce.go

@@ -35,6 +35,7 @@ import (
 
 // KafkaProduceToolBuilder implements the ToolBuilder interface for Kafka client produce operations
 // It provides functionality to build Kafka producer tools
+// /nolint:revive
 type KafkaProduceToolBuilder struct {
 	*builders.BaseToolBuilder
 }
@@ -317,7 +318,7 @@ func (b *KafkaProduceToolBuilder) buildKafkaProduceHandler() func(context.Contex
 				return b.handleError("produce message", results[0].Err), nil
 			}
 		} else {
-			kafkaClient.Produce(timeoutCtx, record, func(_ *kgo.Record, err error) {
+			kafkaClient.Produce(timeoutCtx, record, func(_ *kgo.Record, _ error) {
 				// Log async errors but don't fail since we're async
 				// In the future, this could be enhanced with proper async result handling
 			})

pkg/mcp/builders/kafka/schema_registry.go

@@ -32,6 +32,7 @@ import (
 )
 
 // KafkaSchemaRegistryToolBuilder implements the ToolBuilder interface for Kafka Schema Registry
+// /nolint:revive
 type KafkaSchemaRegistryToolBuilder struct {
 	*builders.BaseToolBuilder
 }
@@ -494,7 +495,7 @@ func (b *KafkaSchemaRegistryToolBuilder) handleSchemaCompatibilitySet(ctx contex
 }
 
 // handleSchemaTypesList handles listing supported schema types
-func (b *KafkaSchemaRegistryToolBuilder) handleSchemaTypesList(ctx context.Context, client *sr.Client, _ mcp.CallToolRequest) (*mcp.CallToolResult, error) {
+func (b *KafkaSchemaRegistryToolBuilder) handleSchemaTypesList(_ context.Context, client *sr.Client, _ mcp.CallToolRequest) (*mcp.CallToolResult, error) {
 	types := []string{"AVRO", "JSON", "PROTOBUF"}
 	return b.marshalResponse(types)
 }

pkg/mcp/builders/kafka/topics.go

@@ -31,6 +31,7 @@ import (
 )
 
 // KafkaTopicsToolBuilder implements the ToolBuilder interface for Kafka Topics
+// /nolint:revive
 type KafkaTopicsToolBuilder struct {
 	*builders.BaseToolBuilder
 }
@@ -306,6 +307,7 @@ func (b *KafkaTopicsToolBuilder) handleKafkaTopicCreate(ctx context.Context, adm
 		return b.handleError("get replication factor", err), nil
 	}
 
+	///nolint:gosec
 	partitions := int32(partitionsNum)
 	replicationFactor := int16(replicationFactorNum)
 

pkg/mcp/builders/pulsar/brokers.go

@@ -30,6 +30,7 @@ import (
 )
 
 // PulsarAdminBrokersToolBuilder implements the ToolBuilder interface for Pulsar admin brokers
+// /nolint:revive
 type PulsarAdminBrokersToolBuilder struct {
 	*builders.BaseToolBuilder
 }