Skip to content

Commit 428d2c1

Browse files
authored
fix: get pulsar service url from cmd (#42)
While working with the external-pulsar setup, I was unable to find a reliable method to inject the pulsar-service-url. This change introduces a fix to parse and apply the service URL from command-line input instead. **=> Updated logic to extract pulsar-service-url from command-line arguments.**
1 parent 372c548 commit 428d2c1

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

pkg/config/options.go

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,8 @@ func (o *Options) AddFlags(cmd *cobra.Command) {
139139
"The bearer token to use for the schema registry [env: SNMCP_KAFKA_SCHEMA_REGISTRY_BEARER_TOKEN]")
140140
cmd.PersistentFlags().StringVar(&o.Pulsar.WebServiceURL, "pulsar-web-service-url", "",
141141
"The web service URL to use for Pulsar [env: SNMCP_PULSAR_WEB_SERVICE_URL]")
142+
cmd.PersistentFlags().StringVar(&o.Pulsar.ServiceURL, "pulsar-service-url", "",
143+
"The service URL to use for Pulsar [env: SNMCP_PULSAR_SERVICE_URL]")
142144
cmd.PersistentFlags().StringVar(&o.Pulsar.AuthPlugin, "pulsar-auth-plugin", "",
143145
"The auth plugin to use for Pulsar [env: SNMCP_PULSAR_AUTH_PLUGIN]")
144146
cmd.PersistentFlags().StringVar(&o.Pulsar.AuthParams, "pulsar-auth-params", "",
@@ -190,6 +192,7 @@ func (o *Options) AddFlags(cmd *cobra.Command) {
190192
viper.BindPFlag("kafka-schema-registry-auth-pass", cmd.PersistentFlags().Lookup("kafka-schema-registry-auth-pass"))
191193
viper.BindPFlag("kafka-schema-registry-bearer-token", cmd.PersistentFlags().Lookup("kafka-schema-registry-bearer-token"))
192194
viper.BindPFlag("pulsar-web-service-url", cmd.PersistentFlags().Lookup("pulsar-web-service-url"))
195+
viper.BindPFlag("pulsar-service-url", cmd.PersistentFlags().Lookup("pulsar-service-url"))
193196
viper.BindPFlag("pulsar-auth-plugin", cmd.PersistentFlags().Lookup("pulsar-auth-plugin"))
194197
viper.BindPFlag("pulsar-auth-params", cmd.PersistentFlags().Lookup("pulsar-auth-params"))
195198
viper.BindPFlag("pulsar-tls-allow-insecure-connection", cmd.PersistentFlags().Lookup("pulsar-tls-allow-insecure-connection"))
@@ -350,6 +353,13 @@ func (o *Options) Complete() error {
350353
o.Pulsar.WebServiceURL = wsURL
351354
}
352355
}
356+
357+
if o.Pulsar.ServiceURL == "" {
358+
if serviceURL := viper.GetString("pulsar-service-url"); serviceURL != "" {
359+
o.Pulsar.ServiceURL = serviceURL
360+
}
361+
}
362+
353363
if o.Pulsar.AuthPlugin == "" {
354364
if authPlugin := viper.GetString("pulsar-auth-plugin"); authPlugin != "" {
355365
o.Pulsar.AuthPlugin = authPlugin

0 commit comments

Comments
 (0)