Skip to content

Commit 2c26a43

Browse files
authored
fix: Rename account id to google service account id (#126)
1 parent 45ed5ac commit 2c26a43

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

examples/gcp/volume-access/main.tf

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ module "sn_managed_cloud_access_bucket" {
88
"<your-ursa-cluster-project-name>"
99
]
1010

11-
account_id = "<your-google-service-account-id>"
11+
# https://cloud.google.com/iam/docs/service-accounts-create#creating
12+
google_service_account_id = "<your-google-service-account-id>"
1213

1314
buckets = [
1415
"<your-gcs-bucket-path>"

modules/gcp/volume-access/main.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@ locals {
2323

2424
}
2525
resource "google_service_account" "gsa" {
26-
account_id = var.account_id
26+
account_id = var.google_service_account_id
2727
project = var.project
28-
display_name = "StreamNative Cloud Control Plane access bucket service account."
28+
display_name = "StreamNative Cloud access bucket service account."
2929
}
3030

3131
resource "google_storage_bucket_iam_member" "gcs" {

modules/gcp/volume-access/variables.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@ variable "streamnative_vendor_access_gsa" {
1515
description = "The GSA will be used by StreamnNative cloud."
1616
}
1717

18-
variable "account_id" {
18+
variable "google_service_account_id" {
1919
type = string
20-
description = "Google Service Account ID, <id>@<your-project>.iam.gserviceaccount.com"
20+
description = "Google Service Account ID, <id>@<your-project>.iam.gserviceaccount.com, ref https://cloud.google.com/iam/docs/service-accounts-create#creating"
2121
}
2222

2323
variable "project" {

0 commit comments

Comments
 (0)