fix(azure): add depends_on for azure vendor-access module (#109)

prevent destroy velero_backup_role before user_access_administrator

Author: freeznet

modules/azure/vendor-access/main.tf

@@ -62,27 +62,31 @@ resource "azurerm_role_definition" "velero_backup_role" {
     not_data_actions = []
     not_actions      = []
   }
+  depends_on = [azurerm_resource_group.aks]
 }
 
 # Grand the sn automation service principal as the Contributor to the AKS resource group
 resource "azurerm_role_assignment" "sn_automation" {
   scope                = azurerm_resource_group.aks.id
   role_definition_name = "Contributor"
   principal_id         = var.sn_automation_principal_id
+  depends_on           = [azurerm_resource_group.aks]
 }
 
 # Grand the sn automation service principal as the Azure Kubernetes Service Cluster Admin Role to the AKS resource group
 resource "azurerm_role_assignment" "sn_automation_cluster_admin" {
   scope                = azurerm_resource_group.aks.id
   role_definition_name = "Azure Kubernetes Service Cluster Admin Role"
   principal_id         = var.sn_automation_principal_id
+  depends_on           = [azurerm_resource_group.aks]
 }
 
 # Grand the sn support service principal as the Azure Kubernetes Service Cluster User Role to the AKS resource group
 resource "azurerm_role_assignment" "sn_support" {
   scope                = azurerm_resource_group.aks.id
   role_definition_name = "Azure Kubernetes Service Cluster User Role"
   principal_id         = var.sn_support_principal_id
+  depends_on           = [azurerm_resource_group.aks]
 }
 
 # Grand the sn automation service principal as the Constrain roles by Role Based Access Control Administrator to the AKS resource group
@@ -92,4 +96,5 @@ resource "azurerm_role_assignment" "user_access_administrator" {
   principal_id         = var.sn_automation_principal_id
   condition_version    = "2.0"
   condition            = templatefile("${path.module}/role-assignment-condition.tpl", { role_definition_id = azurerm_role_definition.velero_backup_role.role_definition_id })
-}
+  depends_on           = [azurerm_role_definition.velero_backup_role]
+}