Skip to content

Commit 8dbe24a

Browse files
Address comment
1 parent 7b88e7c commit 8dbe24a

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

cloud/provider.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ func init() {
217217
"principal_name": "The principal name of apikey, it is the principal name of the service account that the apikey is associated with, it is used to grant permission on pulsar side",
218218
"customized_metadata": "The custom metadata in the api key token",
219219
"enable_iam_account_creation": "Whether to create an IAM account for the service account binding",
220-
"aws_assume_role_arns": "A list of AWS IAM roles' arn which can be assumed by the AWS IAM role created for the service account binding",
220+
"aws_assume_role_arns": "A list of AWS IAM role ARNs which can be assumed by the AWS IAM role created for the service account binding",
221221
}
222222
}
223223

cloud/resource_service_account_binding.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,13 @@ package cloud
1717
import (
1818
"context"
1919
"fmt"
20-
"github.com/streamnative/cloud-api-server/pkg/apis/cloud/v1alpha1"
2120
"strings"
2221
"time"
2322

2423
"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
2524
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/retry"
2625
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
26+
"github.com/streamnative/cloud-api-server/pkg/apis/cloud/v1alpha1"
2727
apierrors "k8s.io/apimachinery/pkg/api/errors"
2828
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2929
)

docs/data-sources/service_account_binding.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ description: |-
2222

2323
### Read-Only
2424

25-
- `aws_assume_role_arns` (List of String) A list of AWS IAM roles' arn which can be assumed by the AWS IAM role created for the service account binding
25+
- `aws_assume_role_arns` (List of String) A list of AWS IAM role ARNs which can be assumed by the AWS IAM role created for the service account binding
2626
- `enable_iam_account_creation` (Boolean) Whether to create an IAM account for the service account binding
2727
- `id` (String) The ID of this resource.
2828
- `pool_member_name` (String) The infrastructure pool member name

docs/resources/service_account_binding.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ description: |-
2222

2323
### Optional
2424

25-
- `aws_assume_role_arns` (List of String) A list of AWS IAM roles' arn which can be assumed by the AWS IAM role created for the service account binding
25+
- `aws_assume_role_arns` (List of String) A list of AWS IAM role ARNs which can be assumed by the AWS IAM role created for the service account binding
2626
- `cluster_name` (String) The pulsar cluster name
2727
- `enable_iam_account_creation` (Boolean) Whether to create an IAM account for the service account binding
2828
- `pool_member_name` (String) The infrastructure pool member name

0 commit comments

Comments
 (0)