Add tests and fix logic

Author: tumppi

src/shared/utils/nodeVersion.test.ts

@@ -0,0 +1,49 @@
+import { isNodeVersionGreaterThanOrEqualTo } from './nodeVersion'
+
+describe('nodeVersion utils', () => {
+    describe('isNodeVersionGreaterThanOrEqualTo', () => {
+        it('returns true when version is greater than required version', () => {
+            expect(isNodeVersionGreaterThanOrEqualTo('14.0.0', '12.0.0')).toBe(true)
+            expect(isNodeVersionGreaterThanOrEqualTo('14.2.0', '14.1.0')).toBe(true)
+            expect(isNodeVersionGreaterThanOrEqualTo('14.2.3', '14.2.2')).toBe(true)
+        })
+
+        it('returns true when version equals required version', () => {
+            expect(isNodeVersionGreaterThanOrEqualTo('14.0.0', '14.0.0')).toBe(true)
+            expect(isNodeVersionGreaterThanOrEqualTo('14.2.1', '14.2.1')).toBe(true)
+        })
+
+        it('returns false when version is less than required version', () => {
+            expect(isNodeVersionGreaterThanOrEqualTo('12.0.0', '14.0.0')).toBe(false)
+            expect(isNodeVersionGreaterThanOrEqualTo('14.1.0', '14.2.0')).toBe(false)
+            expect(isNodeVersionGreaterThanOrEqualTo('14.2.1', '14.2.2')).toBe(false)
+        })
+
+        it('handles partial version numbers correctly', () => {
+            expect(isNodeVersionGreaterThanOrEqualTo('14', '12')).toBe(true)
+            expect(isNodeVersionGreaterThanOrEqualTo('14.2', '14.1')).toBe(true)
+            expect(isNodeVersionGreaterThanOrEqualTo('14.2', '14.2')).toBe(true)
+        })
+
+        it('handles invalid version numbers', () => {
+            expect(isNodeVersionGreaterThanOrEqualTo('invalid', '14.0.0')).toBe(false)
+            expect(isNodeVersionGreaterThanOrEqualTo('14.0.0', 'invalid')).toBe(false)
+            expect(isNodeVersionGreaterThanOrEqualTo('', '')).toBe(false)
+        })
+
+        it('handles versions with different number of parts', () => {
+            // Current version has more parts than required
+            expect(isNodeVersionGreaterThanOrEqualTo('14.0.0', '14.0')).toBe(true)
+            expect(isNodeVersionGreaterThanOrEqualTo('14.0.1', '14')).toBe(true)
+
+            // Required version has more parts than current
+            expect(isNodeVersionGreaterThanOrEqualTo('14.0', '14.0.1')).toBe(false)
+            expect(isNodeVersionGreaterThanOrEqualTo('14', '14.0.1')).toBe(false)
+        })
+
+        it('handles leading zeros in version parts', () => {
+            expect(isNodeVersionGreaterThanOrEqualTo('014.0.0', '14.0.0')).toBe(true)
+            expect(isNodeVersionGreaterThanOrEqualTo('14.02', '14.2')).toBe(true)
+        })
+    })
+})

src/shared/utils/nodeVersion.ts

@@ -1,25 +1,44 @@
+const normalizeVersion = (ver: string) => {
+    if (!ver) return [NaN, NaN, NaN]
+
+    const parts = ver.split('.').map((part) => {
+        const num = parseInt(part, 10)
+        return isNaN(num) ? NaN : num
+    })
+
+    // Check if any part is invalid first
+    if (parts.some(isNaN)) return [NaN, NaN, NaN]
+
+    // Then pad missing parts with 0
+    return [parts[0] ?? 0, parts[1] ?? 0, parts[2] ?? 0]
+}
+
 export const isNodeVersionGreaterThanOrEqualTo = (
     version: string,
     requiredVersion: string,
 ): boolean => {
-    // Split versions and pad with zeros if parts are missing
-    const normalize = (ver: string) => {
-        const parts = ver.split('.').map((part) => parseInt(part, 10))
-        return [parts[0] || 0, parts[1] || 0, parts[2] || 0]
-    }
-
-    const [major, minor, patch] = normalize(version)
-    const [requiredMajor, requiredMinor, requiredPatch] = normalize(requiredVersion)
+    const [major, minor, patch] = normalizeVersion(version)
+    const [requiredMajor, requiredMinor, requiredPatch] =
+        normalizeVersion(requiredVersion)
 
     // Handle invalid inputs
-    if (isNaN(major) || isNaN(requiredMajor)) {
+    if (
+        isNaN(major) ||
+        isNaN(minor) ||
+        isNaN(patch) ||
+        isNaN(requiredMajor) ||
+        isNaN(requiredMinor) ||
+        isNaN(requiredPatch)
+    ) {
         return false
     }
 
-    return (
-        major > requiredMajor ||
-        (major === requiredMajor &&
-            (minor > requiredMinor ||
-                (minor === requiredMinor && patch >= requiredPatch)))
-    )
+    // Compare each part sequentially
+    if (major !== requiredMajor) {
+        return major > requiredMajor
+    }
+    if (minor !== requiredMinor) {
+        return minor > requiredMinor
+    }
+    return patch >= requiredPatch
 }