refactor(config): validate Chain() parameters

Author: kare

packages/config/src/index.ts

@@ -39,7 +39,13 @@ export class Chain implements ChainJSON {
         public rpcEndpoints: RPCEndpoint[],
         public contracts: Contracts,
     ) {
+        if (name === "") {
+            throw new Error("Chain name is required")
+        }
         this.name = name
+        if (id < 0) {
+            throw new Error("Chain ID cannot be negative")
+        }
         this.id = id
         this.rpcEndpoints = new Array<RPCEndpoint>()
         for (const rpcEndpoint of rpcEndpoints) {

packages/config/test/index.test.ts

@@ -42,4 +42,63 @@ describe("Load configuration from JSON file", () => {
         const chain = new config.Chain("GNOSIS", 123, new Array<config.RPCEndpoint>(), new config.Contracts())
         assert.equal(chain.toString(), "gnosis")
     })
+    describe("Chain constructor", () => {
+        const testCases: {
+            name: string;
+            chain: {
+                name: string;
+                id: number;
+                rpcEndpoints: config.RPCEndpoint[];
+                contracts: config.Contracts;
+            };
+            expectedErrorMessage: string;
+        }[] = [
+            {
+                name: "name cannot be empty",
+                chain: {
+                    name: "",
+                    id: 0,
+                    rpcEndpoints: new Array<config.RPCEndpoint>(),
+                    contracts: new config.Contracts(),
+                },
+                expectedErrorMessage: "Chain name is required",
+            },
+            {
+                name: "id cannot be negative",
+                chain: {
+                    name: "ethereum",
+                    id: -1,
+                    rpcEndpoints: new Array<config.RPCEndpoint>(),
+                    contracts: new config.Contracts(),
+                },
+                expectedErrorMessage: "Chain ID cannot be negative",
+            },
+            {
+                name: "all good",
+                chain: {
+                    name: "ethereum",
+                    id: 1,
+                    rpcEndpoints: new Array<config.RPCEndpoint>(),
+                    contracts: new config.Contracts(),
+                },
+                expectedErrorMessage: "",
+            },
+        ]
+        testCases.forEach((tc) => {
+            it(tc.name, async () => {
+                try {
+                    new config.Chain(tc.chain.name, tc.chain.id, tc.chain.rpcEndpoints, tc.chain.contracts)
+                    if (tc.expectedErrorMessage !== "") {
+                        assert.fail("expecting error")
+                    }
+                } catch (err: any) {
+                    if (tc.expectedErrorMessage !== "") {
+                        assert.equal(err.message, tc.expectedErrorMessage)
+                    } else {
+                        assert.fail(`unexpected error: "${err}"`)
+                    }
+                }
+            })
+        })
+    })
 })