Skip to content

Commit 1b2eb13

Browse files
authored
refactor: Restore strict noImplicitOverride for packages with no protobuf code (#3294)
This pull request removes the `noImplicitOverride` option from several TypeScript configuration files across multiple packages. > [!NOTE] > Previously, `noImplicitOverride` was explicitly set to `false` across the app. This was not a design choice, but a workaround: the auto-generated protobuf types were incompatible with `noImplicitOverride`, and there was no proper isolation at the tsconfig level to scope that limitation. As a result, stricter typing guarantees were relaxed globally. > > Change in this PR is a step towards bringing the restriction back, making the types stricter again. ### Changes **TypeScript configuration cleanup:** * Removed the `noImplicitOverride` option from `tsconfig.node.json` files in `autocertifier-server`, `cdn-location`, and `geoip-location` packages. [[1]](diffhunk://#diff-b8ca01c11975250ba2d1cf703ecb4dfb3a3197b14d1e0fb1c92cab47c0f393efL4-R4) [[2]](diffhunk://#diff-829757d9b00ea7fbff093ee2e216391cd3edcd5f46ddf05bde89e75eae6bfe83L4-R4) [[3]](diffhunk://#diff-12d458a7541ce0f79df26b4a0912690fb4f49f715022716a14e166027152cb5cL4-R4) * Removed the `noImplicitOverride` option from `tsconfig.karma.json` files in `dht`, `proto-rpc`, `trackerless-network`, and `utils` packages. [[1]](diffhunk://#diff-ee756c159139fc121c7690550bbdedebbe93f791e29c68f80247e93b46a72287L5) [[2]](diffhunk://#diff-07b674f7bfb21f19369939a17a7a6ae2623d3b6de78fc89e1214d07764ef38c5L5) [[3]](diffhunk://#diff-5c2698258694c8934a41c50bf6374b3340732bfc80bd5eb9a407c89d8b46d0b7L5) [[4]](diffhunk://#diff-a9339bd6577b7c530e347d4f43de35b290cc6536979b7edf04bbd809a63a68a7L5) * Removed the `noImplicitOverride` option from `tsconfig.jest.json` in the `cli-tools` package.
1 parent 5c840c7 commit 1b2eb13

File tree

8 files changed

+4
-12
lines changed

8 files changed

+4
-12
lines changed

packages/autocertifier-server/tsconfig.node.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
{
22
"extends": "../../tsconfig.node.json",
33
"compilerOptions": {
4-
"outDir": "dist",
5-
"noImplicitOverride": false
4+
"outDir": "dist"
65
},
76
"include": [
87
"src",

packages/cdn-location/tsconfig.node.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
{
22
"extends": "../../tsconfig.node.json",
33
"compilerOptions": {
4-
"outDir": "dist",
5-
"noImplicitOverride": false
4+
"outDir": "dist"
65
},
76
"include": [
87
"src"

packages/cli-tools/tsconfig.jest.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@
55
"node",
66
"jest",
77
"@streamr/test-utils/customMatcherTypes"
8-
],
9-
"noImplicitOverride": false
8+
]
109
},
1110
"include": [
1211
"package.json",

packages/dht/tsconfig.karma.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
"extends": "../../tsconfig.karma.json",
33
"compilerOptions": {
44
"outDir": "dist",
5-
"noImplicitOverride": false,
65
"types": [
76
"jest",
87
"jest-extended"

packages/geoip-location/tsconfig.node.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
{
22
"extends": "../../tsconfig.node.json",
33
"compilerOptions": {
4-
"outDir": "dist",
5-
"noImplicitOverride": false
4+
"outDir": "dist"
65
},
76
"include": [
87
"src"

packages/proto-rpc/tsconfig.karma.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
"extends": "../../tsconfig.karma.json",
33
"compilerOptions": {
44
"outDir": "dist",
5-
"noImplicitOverride": false,
65
"types": [
76
"jest"
87
]

packages/trackerless-network/tsconfig.karma.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
"extends": "../../tsconfig.karma.json",
33
"compilerOptions": {
44
"outDir": "dist",
5-
"noImplicitOverride": false,
65
"types": [
76
"jest",
87
"@streamr/test-utils/customMatcherTypes"

packages/utils/tsconfig.karma.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
"extends": "../../tsconfig.karma.json",
33
"compilerOptions": {
44
"outDir": "dist",
5-
"noImplicitOverride": false,
65
"types": [
76
"jest",
87
"jest-extended"

0 commit comments

Comments
 (0)