Commit 1b2eb13
authored
refactor: Restore strict
This pull request removes the `noImplicitOverride` option from several
TypeScript configuration files across multiple packages.
> [!NOTE]
> Previously, `noImplicitOverride` was explicitly set to `false` across
the app. This was not a design choice, but a workaround: the
auto-generated protobuf types were incompatible with
`noImplicitOverride`, and there was no proper isolation at the tsconfig
level to scope that limitation. As a result, stricter typing guarantees
were relaxed globally.
>
> Change in this PR is a step towards bringing the restriction back,
making the types stricter again.
### Changes
**TypeScript configuration cleanup:**
* Removed the `noImplicitOverride` option from `tsconfig.node.json`
files in `autocertifier-server`, `cdn-location`, and `geoip-location`
packages.
[[1]](diffhunk://#diff-b8ca01c11975250ba2d1cf703ecb4dfb3a3197b14d1e0fb1c92cab47c0f393efL4-R4)
[[2]](diffhunk://#diff-829757d9b00ea7fbff093ee2e216391cd3edcd5f46ddf05bde89e75eae6bfe83L4-R4)
[[3]](diffhunk://#diff-12d458a7541ce0f79df26b4a0912690fb4f49f715022716a14e166027152cb5cL4-R4)
* Removed the `noImplicitOverride` option from `tsconfig.karma.json`
files in `dht`, `proto-rpc`, `trackerless-network`, and `utils`
packages.
[[1]](diffhunk://#diff-ee756c159139fc121c7690550bbdedebbe93f791e29c68f80247e93b46a72287L5)
[[2]](diffhunk://#diff-07b674f7bfb21f19369939a17a7a6ae2623d3b6de78fc89e1214d07764ef38c5L5)
[[3]](diffhunk://#diff-5c2698258694c8934a41c50bf6374b3340732bfc80bd5eb9a407c89d8b46d0b7L5)
[[4]](diffhunk://#diff-a9339bd6577b7c530e347d4f43de35b290cc6536979b7edf04bbd809a63a68a7L5)
* Removed the `noImplicitOverride` option from `tsconfig.jest.json` in
the `cli-tools` package.noImplicitOverride for packages with no protobuf code (#3294)1 parent 5c840c7 commit 1b2eb13
File tree
8 files changed
+4
-12
lines changed- packages
- autocertifier-server
- cdn-location
- cli-tools
- dht
- geoip-location
- proto-rpc
- trackerless-network
- utils
8 files changed
+4
-12
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
| 4 | + | |
6 | 5 | | |
7 | 6 | | |
8 | 7 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
| 4 | + | |
6 | 5 | | |
7 | 6 | | |
8 | 7 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | | - | |
| 8 | + | |
10 | 9 | | |
11 | 10 | | |
12 | 11 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | 5 | | |
7 | 6 | | |
8 | 7 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
| 4 | + | |
6 | 5 | | |
7 | 6 | | |
8 | 7 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | 5 | | |
7 | 6 | | |
8 | 7 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | 5 | | |
7 | 6 | | |
8 | 7 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | 5 | | |
7 | 6 | | |
8 | 7 | | |
| |||
0 commit comments