Skip to content

Commit 39cfbb9

Browse files
authored
fix(Autocertifier-server): Fix error when cleaning up subdomains (#3218)
## Summary Added `Promise.allSettled` instead of `Promise.all` to get rid of failing `createNewCertificateForSubdomain` requests
1 parent b7b2fa7 commit 39cfbb9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

packages/autocertifier-server/src/AutoCertifierServer.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ export class AutoCertifierServer implements RestInterface, ChallengeManager {
119119
const subdomains = await this.database!.getSubdomainsByIpAndPort(ipAddress, streamrWebSocketPort)
120120
logger.info('Deleting all subdomains from ip: ' + ipAddress + ' port: '
121121
+ streamrWebSocketPort + ' number of subdomains: ' + subdomains.length, { subdomains })
122-
await Promise.all(subdomains.map((subdomain) =>
122+
await Promise.allSettled(subdomains.map((subdomain) =>
123123
this.route53Api!.deleteRecord(
124124
RRType.A,
125125
subdomain.subdomainName + '.' + this.domainName,

0 commit comments

Comments
 (0)