refactor: Enable noImplicitOverride on the remaining non-generated code (#3304)

mondoreale · Copilot · web-flow · commit 58d67f8942ff · 2026-01-06T17:21:36.000+01:00
This pull request refactors TypeScript configuration across multiple
packages to improve handling of generated code and project references,
and updates some package scripts for consistency. It also includes minor
code improvements for clarity and correctness.

&gt; [!NOTE]
&gt; Previously, `noImplicitOverride` was explicitly set to `false` across
the app. This was not a design choice, but a workaround: the
auto-generated protobuf types were incompatible with
`noImplicitOverride`, and there was no proper isolation at the tsconfig
level to scope that limitation. As a result, stricter typing guarantees
were relaxed globally.
&gt; 
&gt; Changes in this PR are the remaining step towards bringing the
restriction back, making the types stricter again.

### Changes

**TypeScript configuration improvements:**

* Introduced separate `tsconfig.generated.json` files in several
packages (such as `autocertifier-client`, `dht`, `proto-rpc`, and `sdk`)
to isolate generated code and manage its compilation independently.
These are now referenced in the main and test TypeScript configs.
[[1]](diffhunk://#diff-9950b7b77c8a7db18e0ef901b107025b666a0e0a27a436616b43c2fedb34d6c1R1-R10)
[[2]](diffhunk://#diff-de621a41125dd18f6388b50a2ec6281e3b8fa498b793969c76dc0a8d8531f68aR1-R11)
[[3]](diffhunk://#diff-eab3f7cef1e6788318415e3df2a580ecfc85bf2902a773843b518ba10da07d45R1-R10)
* Updated `tsconfig.json` and `tsconfig.jest.json` files to remove
`noImplicitOverride: false` (now set only in generated configs), exclude
generated directories from main source includes, and add references to
the new generated configs.
[[1]](diffhunk://#diff-ae13578e8d026eec67d6b00c439076ab2fc27081e16cb0744b996b414ec28a98L4-R11)
[[2]](diffhunk://#diff-70012901c7a9586d8be81a0f0a58cf6545215824aa31d03c4933123d0df69280L4-R16)
[[3]](diffhunk://#diff-57fd489a6641c04408b02f51816e203938c2d4d819f96f2aee228814678e7d9fL3-R10)
[[4]](diffhunk://#diff-1f70c1f766410506b8ac4d72e9e2cdf43c0dd3a95837202876180763d02093e2L3-R11)
[[5]](diffhunk://#diff-62ec9179a1fd352f07b1db2aae889fa66e81cf7f72ceffe25ae527ff7ad6c492L8-R23)
[[6]](diffhunk://#diff-24db07be3ce94f0c29f9b1cdb5eb169b812640e615757b63168ec8eb28d605c6L6-R6)
[[7]](diffhunk://#diff-24db07be3ce94f0c29f9b1cdb5eb169b812640e615757b63168ec8eb28d605c6R18-R22)
[[8]](diffhunk://#diff-ae13578e8d026eec67d6b00c439076ab2fc27081e16cb0744b996b414ec28a98L4-R11)

**Project reference and dependency cleanup:**

* Reordered and clarified project references in several `tsconfig.json`
files to ensure correct dependency resolution and build order.
[[1]](diffhunk://#diff-6911c66f995472db595934d34bed8bb3b9d4f5f4e8dcef1329a16d498928e684R11-R14)
[[2]](diffhunk://#diff-38daa775ecafcf440e7c2b9817052481019197dfba8e0bbb482e7ce5efe0cfafR13-R16)
[[3]](diffhunk://#diff-62ec9179a1fd352f07b1db2aae889fa66e81cf7f72ceffe25ae527ff7ad6c492L8-R23)
[[4]](diffhunk://#diff-70012901c7a9586d8be81a0f0a58cf6545215824aa31d03c4933123d0df69280L4-R16)
[[5]](diffhunk://#diff-ae13578e8d026eec67d6b00c439076ab2fc27081e16cb0744b996b414ec28a98L4-R11)

**Package script updates:**

* Changed the `check` script in several `package.json` files to use `tsc
-b` (build mode) instead of `tsc -p`, aligning with project references
and improving type checking.
[[1]](diffhunk://#diff-48deceddbbe98a41ff1d0f560db132548031fbd96d790c09ffeed924a20e8a05L29-R29)
[[2]](diffhunk://#diff-e81a3463e3e75e879c7fa17b1609d29d02bb633aaceb777564c9f88a48729ff9L24-R24)
[[3]](diffhunk://#diff-77164cc5c071d1488e1cf72c0f91fdd99dd8976edb5004c83198bbd517039572L39-R39)
[[4]](diffhunk://#diff-e73f8b6abf767f5f6271d1dcbf5188b40d63732e6a8cd772b44f677c2fc36bc1L23-R23)

**Minor code improvements:**

* Added `override` keyword to overridden methods in test and
implementation files for better type safety and clarity.
[[1]](diffhunk://#diff-5e6ebf26c1a7f17946b4a79009d4c286b6a553a215db065393b9f0e32f81dab0L20-R20)
[[2]](diffhunk://#diff-f03278bf6d70079d4859c692194a7896c0ef0270919070d88bd9a739979cf4c5L65-R65)
[[3]](diffhunk://#diff-f03278bf6d70079d4859c692194a7896c0ef0270919070d88bd9a739979cf4c5L93-R93)
[[4]](diffhunk://#diff-0c8af68961e03aa39330bdcca6e9201cc7421497e5dfe3fb4eddfd62b358e22aL29-R29)

---------

Co-authored-by: Copilot &lt;175728472+Copilot@users.noreply.github.com&gt;
diff --git a/packages/autocertifier-client/tsconfig.generated.json b/packages/autocertifier-client/tsconfig.generated.json
@@ -0,0 +1,10 @@
+{
+  "extends": "./tsconfig.json",
+  "compilerOptions": {
+    "noImplicitOverride": false
+  },
+  "include": [
+    "generated"
+  ],
+  "exclude": []
+}
diff --git a/packages/autocertifier-client/tsconfig.json b/packages/autocertifier-client/tsconfig.json
@@ -1,14 +1,13 @@
 {
   "extends": "../../tsconfig.node.json",
   "compilerOptions": {
-    "outDir": "dist",
-    "noImplicitOverride": false
+    "outDir": "dist"
   },
   "include": [
-    "src",
-    "generated"
+    "src"
   ],
   "references": [
-    { "path": "../utils" }
+    { "path": "../utils" },
+    { "path": "./tsconfig.generated.json" }
   ]
 }
diff --git a/packages/autocertifier-server/tsconfig.json b/packages/autocertifier-server/tsconfig.json
@@ -8,9 +8,9 @@
     "bin"
   ],
   "references": [
+    { "path": "../utils" },
     { "path": "../autocertifier-client" },
-    { "path": "../dht" },
     { "path": "../proto-rpc" },
-    { "path": "../utils" }
+    { "path": "../dht" }
   ]
 }
diff --git a/packages/cli-tools/tsconfig.json b/packages/cli-tools/tsconfig.json
@@ -10,9 +10,9 @@
     "bin"
   ],
   "references": [
+    { "path": "../utils" },
     { "path": "../dht" },
-    { "path": "../sdk" },
     { "path": "../trackerless-network" },
-    { "path": "../utils" }
+    { "path": "../sdk" }
   ]
 }
diff --git a/packages/dht/package.json b/packages/dht/package.json
@@ -26,7 +26,7 @@
     "postbuild": "./scripts/postbuild.sh",
     "build": "tsc -b",
     "build-browser": "webpack --mode=development --progress",
-    "check": "tsc -p tsconfig.jest.json",
+    "check": "tsc -b tsconfig.jest.json",
     "clean": "jest --clearCache --config '{}' || true; rm -rf dist generated *.tsbuildinfo node_modules/.cache || true",
     "eslint": "eslint --cache --cache-location=node_modules/.cache/.eslintcache/ '*/**/*.{js,ts}'",
     "test": "npm run test-unit && npm run test-integration && npm run test-end-to-end",
diff --git a/packages/dht/test/unit/PeerManager.test.ts b/packages/dht/test/unit/PeerManager.test.ts
@@ -17,7 +17,7 @@ const createDhtNodeRpcRemote = (
 ) => {
     const remote = new class extends DhtNodeRpcRemote {
         // eslint-disable-next-line class-methods-use-this
-        async ping(): Promise<boolean> {
+        override async ping(): Promise<boolean> {
             return !pingFailures.has(toNodeId(peerDescriptor))
         }
     }(localPeerDescriptor, peerDescriptor, undefined as any, new MockRpcCommunicator())
diff --git a/packages/dht/test/utils/utils.ts b/packages/dht/test/utils/utils.ts
@@ -62,7 +62,7 @@ export const createMockRingNode = async (
         rpcRequestTimeout: 5000
     }
     const node = new class extends DhtNode {
-        async stop(): Promise<void> {
+        override async stop(): Promise<void> {
             await super.stop()
             await mockConnectionManager.stop()
         }
@@ -90,7 +90,7 @@ export const createMockConnectionDhtNode = async (
         rpcRequestTimeout: 5000
     }
     const node = new class extends DhtNode {
-        async stop(): Promise<void> {
+        override async stop(): Promise<void> {
             await super.stop()
             await mockConnectionManager.stop()
         }
diff --git a/packages/dht/tsconfig.generated.json b/packages/dht/tsconfig.generated.json
@@ -0,0 +1,10 @@
+{
+  "extends": "./tsconfig.json",
+  "compilerOptions": {
+    "noImplicitOverride": false
+  },
+  "include": [
+    "generated"
+  ],
+  "exclude": []
+}
diff --git a/packages/dht/tsconfig.jest.json b/packages/dht/tsconfig.jest.json
@@ -1,13 +1,12 @@
 {
   "extends": "../../tsconfig.jest.json",
-  "compilerOptions": {
-    "noImplicitOverride": false
-  },
   "include": [
     "src",
-    "generated",
     "test",
     "package.json",
     "scripts"
+  ],
+  "references": [
+    { "path": "./tsconfig.generated.json" }
   ]
 }
diff --git a/packages/dht/tsconfig.json b/packages/dht/tsconfig.json
@@ -1,19 +1,18 @@
 {
   "extends": "../../tsconfig.node.json",
   "compilerOptions": {
-    "outDir": "dist",
-    "noImplicitOverride": false
+    "outDir": "dist"
   },
   "include": [
     "src",
-    "generated",
     "package.json"
   ],
   "references": [
-    { "path": "../autocertifier-client" },
+    { "path": "../utils" },
+    { "path": "../proto-rpc" },
     { "path": "../cdn-location" },
     { "path": "../geoip-location" },
-    { "path": "../proto-rpc" },
-    { "path": "../utils" }
+    { "path": "../autocertifier-client" },
+    { "path": "./tsconfig.generated.json" }
   ]
 }
diff --git a/packages/proto-rpc/package.json b/packages/proto-rpc/package.json
@@ -21,7 +21,7 @@
     "prebuild": "./proto.sh",
     "build": "tsc -b",
     "build-browser": "webpack --mode=development --progress",
-    "check": "./test-proto.sh && tsc -p tsconfig.jest.json",
+    "check": "./test-proto.sh && tsc -b tsconfig.jest.json",
     "clean": "jest --clearCache --config '{}' || true; rm -rf dist generated *.tsbuildinfo node_modules/.cache || true",
     "eslint": "./test-proto.sh && eslint --cache --cache-location=node_modules/.cache/.eslintcache/ '*/**/*.{js,ts}'",
     "test": "./test-proto.sh && npm run test-unit && npm run test-integration",
diff --git a/packages/proto-rpc/tsconfig.generated.json b/packages/proto-rpc/tsconfig.generated.json
@@ -0,0 +1,11 @@
+{
+  "extends": "./tsconfig.json",
+  "compilerOptions": {
+    "noImplicitOverride": false
+  },
+  "include": [
+    "generated",
+    "test/proto"
+  ],
+  "exclude": []
+}
diff --git a/packages/proto-rpc/tsconfig.jest.json b/packages/proto-rpc/tsconfig.jest.json
@@ -1,11 +1,13 @@
 {
   "extends": "../../tsconfig.jest.json",
-  "compilerOptions": {
-    "noImplicitOverride": false
-  },
   "include": [
     "src",
-    "generated",
     "test"
+  ],
+  "exclude": [
+    "test/proto"
+  ],
+  "references": [
+    { "path": "./tsconfig.generated.json" }
   ]
 }
diff --git a/packages/proto-rpc/tsconfig.json b/packages/proto-rpc/tsconfig.json
@@ -1,14 +1,13 @@
 {
   "extends": "../../tsconfig.node.json",
   "compilerOptions": {
-    "outDir": "dist",
-    "noImplicitOverride": false
+    "outDir": "dist"
   },
   "include": [
-    "src",
-    "generated"
+    "src"
   ],
   "references": [
-    { "path": "../utils" }
+    { "path": "../utils" },
+    { "path": "./tsconfig.generated.json" }
   ]
 }
diff --git a/packages/sdk/package.json b/packages/sdk/package.json
@@ -36,7 +36,7 @@
     "build-browser": "npm run build-browser-development && npm run build-browser-production",
     "build-browser-development": "NODE_ENV=development webpack --mode=development --progress",
     "build-browser-production": "NODE_ENV=production webpack --mode=production --progress",
-    "check": "tsc -p tsconfig.jest.json",
+    "check": "tsc -b tsconfig.jest.json",
     "clean": "jest --clearCache --config '{}' || true; rm -rf dist src/generated *.tsbuildinfo node_modules/.cache || true",
     "eslint": "eslint --cache --cache-location=node_modules/.cache/.eslintcache/ '*/**/*.{js,ts,mts}'",
     "generate-protoc-code": "./proto.sh",
diff --git a/packages/sdk/src/identity/EthereumKeyPairIdentity.ts b/packages/sdk/src/identity/EthereumKeyPairIdentity.ts
@@ -26,7 +26,7 @@ export class EthereumKeyPairIdentity extends KeyPairIdentity {
         return signingUtil.createSignature(payload, this.privateKey)
     }
 
-    async getTransactionSigner(rpcProviderSource: RpcProviderSource): Promise<SignerWithProvider> {
+    override async getTransactionSigner(rpcProviderSource: RpcProviderSource): Promise<SignerWithProvider> {
         const primaryProvider = rpcProviderSource.getProvider()
         return new Wallet(binaryToHex(this.privateKey), primaryProvider) as SignerWithProvider
     }
diff --git a/packages/sdk/tsconfig.generated.json b/packages/sdk/tsconfig.generated.json
@@ -0,0 +1,10 @@
+{
+  "extends": "./tsconfig.json",
+  "compilerOptions": {
+    "noImplicitOverride": false
+  },
+  "include": [
+    "src/generated"
+  ],
+  "exclude": []
+}
diff --git a/packages/sdk/tsconfig.jest.json b/packages/sdk/tsconfig.jest.json
@@ -3,8 +3,7 @@
   "compilerOptions": {
     "lib": ["es2021"],
     "experimentalDecorators": true,
-    "emitDecoratorMetadata": true,
-    "noImplicitOverride": false
+    "emitDecoratorMetadata": true
   },
   "include": [
     "package.json",
@@ -16,6 +15,10 @@
     "scripts"
   ],
   "exclude": [
+    "src/generated",
     "test/exports"
+  ],
+  "references": [
+    { "path": "./tsconfig.generated.json" }
   ]
 }
diff --git a/packages/sdk/tsconfig.json b/packages/sdk/tsconfig.json
@@ -5,20 +5,21 @@
     "declarationDir": "dist/types",
     "lib": ["es2021"],
     "experimentalDecorators": true,
-    "emitDecoratorMetadata": true,
-    "noImplicitOverride": false
+    "emitDecoratorMetadata": true
   },
   "include": [
     "src",
     "src/**/*.json"
   ],
   "exclude": [
+    "src/generated",
     "src/exports-esm.mjs"
   ],
   "references": [
-    { "path": "../dht" },
+    { "path": "../utils" },
     { "path": "../proto-rpc" },
+    { "path": "../dht" },
     { "path": "../trackerless-network" },
-    { "path": "../utils" }
+    { "path": "./tsconfig.generated.json" }
   ]
 }
diff --git a/packages/trackerless-network/package.json b/packages/trackerless-network/package.json
@@ -20,7 +20,7 @@
     "build": "tsc -b",
     "build-browser": "webpack --mode=development --progress",
     "prebuild": "./proto.sh",
-    "check": "tsc -p tsconfig.jest.json",
+    "check": "tsc -b tsconfig.jest.json",
     "clean": "jest --clearCache --config '{}' || true; rm -rf dist generated *.tsbuildinfo node_modules/.cache || true",
     "coverage": "jest --coverage",
     "eslint": "eslint --cache --cache-location=node_modules/.cache/.eslintcache/ '*/**/*.{js,ts}'",
diff --git a/packages/trackerless-network/tsconfig.generated.json b/packages/trackerless-network/tsconfig.generated.json
@@ -0,0 +1,10 @@
+{
+  "extends": "./tsconfig.json",
+  "compilerOptions": {
+    "noImplicitOverride": false
+  },
+  "include": [
+    "generated"
+  ],
+  "exclude": []
+}
diff --git a/packages/trackerless-network/tsconfig.jest.json b/packages/trackerless-network/tsconfig.jest.json
@@ -1,12 +1,11 @@
 {
   "extends": "../../tsconfig.jest.json",
-  "compilerOptions": {
-    "noImplicitOverride": false
-  },
   "include": [
     "src",
-    "generated",
     "package.json",
     "test"
+  ],
+  "references": [
+    { "path": "./tsconfig.generated.json" }
   ]
 }
diff --git a/packages/trackerless-network/tsconfig.json b/packages/trackerless-network/tsconfig.json
@@ -1,17 +1,16 @@
 {
   "extends": "../../tsconfig.node.json",
   "compilerOptions": {
-    "outDir": "dist",
-    "noImplicitOverride": false
+    "outDir": "dist"
   },
   "include": [
     "src",
-    "generated",
     "package.json"
   ],
   "references": [
-    { "path": "../dht" },
+    { "path": "../utils" },
     { "path": "../proto-rpc" },
-    { "path": "../utils" }
+    { "path": "../dht" },
+    { "path": "./tsconfig.generated.json" }
   ]
 }

Original file line number	Diff line number	Diff line change
`@@ -1,14 +1,13 @@`
`1`	`1`	`{`
`2`	`2`	`"extends": "../../tsconfig.node.json",`
`3`	`3`	`"compilerOptions": {`
`4`		`- "outDir": "dist",`
`5`		`- "noImplicitOverride": false`
	`4`	`+ "outDir": "dist"`
`6`	`5`	`},`
`7`	`6`	`"include": [`
`8`		`- "src",`
`9`		`- "generated"`
	`7`	`+ "src"`
`10`	`8`	`],`
`11`	`9`	`"references": [`
`12`		`- { "path": "../utils" }`
	`10`	`+ { "path": "../utils" },`
	`11`	`+ { "path": "./tsconfig.generated.json" }`
`13`	`12`	`]`
`14`	`13`	`}`
Original file line number	Diff line number	Diff line change
`@@ -8,9 +8,9 @@`
`8`	`8`	`"bin"`
`9`	`9`	`],`
`10`	`10`	`"references": [`
	`11`	`+ { "path": "../utils" },`
`11`	`12`	`{ "path": "../autocertifier-client" },`
`12`		`- { "path": "../dht" },`
`13`	`13`	`{ "path": "../proto-rpc" },`
`14`		`- { "path": "../utils" }`
	`14`	`+ { "path": "../dht" }`
`15`	`15`	`]`
`16`	`16`	`}`
Original file line number	Diff line number	Diff line change
`@@ -10,9 +10,9 @@`
`10`	`10`	`"bin"`
`11`	`11`	`],`
`12`	`12`	`"references": [`
	`13`	`+ { "path": "../utils" },`
`13`	`14`	`{ "path": "../dht" },`
`14`		`- { "path": "../sdk" },`
`15`	`15`	`{ "path": "../trackerless-network" },`
`16`		`- { "path": "../utils" }`
	`16`	`+ { "path": "../sdk" }`
`17`	`17`	`]`
`18`	`18`	`}`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ const createDhtNodeRpcRemote = (`
`17`	`17`	`) => {`
`18`	`18`	`const remote = new class extends DhtNodeRpcRemote {`
`19`	`19`	`// eslint-disable-next-line class-methods-use-this`
`20`		`- async ping(): Promise<boolean> {`
	`20`	`+ override async ping(): Promise<boolean> {`
`21`	`21`	`return !pingFailures.has(toNodeId(peerDescriptor))`
`22`	`22`	`}`
`23`	`23`	`}(localPeerDescriptor, peerDescriptor, undefined as any, new MockRpcCommunicator())`
Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ export const createMockRingNode = async (`
`62`	`62`	`rpcRequestTimeout: 5000`
`63`	`63`	`}`
`64`	`64`	`const node = new class extends DhtNode {`
`65`		`- async stop(): Promise<void> {`
	`65`	`+ override async stop(): Promise<void> {`
`66`	`66`	`await super.stop()`
`67`	`67`	`await mockConnectionManager.stop()`
`68`	`68`	`}`
`@@ -90,7 +90,7 @@ export const createMockConnectionDhtNode = async (`
`90`	`90`	`rpcRequestTimeout: 5000`
`91`	`91`	`}`
`92`	`92`	`const node = new class extends DhtNode {`
`93`		`- async stop(): Promise<void> {`
	`93`	`+ override async stop(): Promise<void> {`
`94`	`94`	`await super.stop()`
`95`	`95`	`await mockConnectionManager.stop()`
`96`	`96`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,13 +1,12 @@`
`1`	`1`	`{`
`2`	`2`	`"extends": "../../tsconfig.jest.json",`
`3`		`- "compilerOptions": {`
`4`		`- "noImplicitOverride": false`
`5`		`- },`
`6`	`3`	`"include": [`
`7`	`4`	`"src",`
`8`		`- "generated",`
`9`	`5`	`"test",`
`10`	`6`	`"package.json",`
`11`	`7`	`"scripts"`
	`8`	`+ ],`
	`9`	`+ "references": [`
	`10`	`+ { "path": "./tsconfig.generated.json" }`
`12`	`11`	`]`
`13`	`12`	`}`