Skip to content

Commit 5f158ab

Browse files
committed
Make Identity#getPrivateKey() synchronous
1 parent afb7cab commit 5f158ab

File tree

3 files changed

+7
-9
lines changed

3 files changed

+7
-9
lines changed

packages/sdk/src/identity/Identity.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export abstract class Identity {
2626
* Returns undefined for identities that rely on external signers (e.g. browser wallets).
2727
*/
2828
// eslint-disable-next-line class-methods-use-this
29-
getPrivateKey(): Promise<Uint8Array> | undefined {
29+
getPrivateKey(): Uint8Array | undefined {
3030
return undefined
3131
}
3232
}

packages/sdk/src/identity/KeyPairIdentity.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ export abstract class KeyPairIdentity extends Identity {
3030
return this.publicKeyString
3131
}
3232

33-
override getPrivateKey(): Promise<Uint8Array> {
34-
return Promise.resolve(this.privateKey)
33+
override getPrivateKey(): Uint8Array {
34+
return this.privateKey
3535
}
3636

3737
// eslint-disable-next-line class-methods-use-this

packages/sdk/src/signature/MessageSigner.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@ export class MessageSigner {
3232

3333
// Use worker-based signing if identity provides a private key and signature type supports it
3434
// ERC-1271 signatures require on-chain verification and must be handled by the identity directly
35-
const privateKeyPromise = this.identity.getPrivateKey()
36-
if (privateKeyPromise !== undefined && signatureType !== SignatureType.ERC_1271) {
37-
signature = await this.createSignatureInWorker(opts, signatureType, privateKeyPromise)
35+
const privateKey = this.identity.getPrivateKey()
36+
if (privateKey !== undefined && signatureType !== SignatureType.ERC_1271) {
37+
signature = await this.createSignatureInWorker(opts, signatureType, privateKey)
3838
} else {
3939
signature = await this.identity.createMessageSignature(createSignaturePayload(opts))
4040
}
@@ -49,10 +49,8 @@ export class MessageSigner {
4949
private async createSignatureInWorker(
5050
opts: MarkRequired<Omit<StreamMessageOptions, 'signature' | 'signatureType'>, 'messageType'>,
5151
signatureType: SignatureType,
52-
privateKeyPromise: Promise<Uint8Array>
52+
privateKey: Uint8Array
5353
): Promise<Uint8Array> {
54-
const privateKey = await privateKeyPromise
55-
5654
const result = await this.getSigning().createSignature({
5755
payloadInput: opts,
5856
privateKey,

0 commit comments

Comments
 (0)