Skip to content

Commit b70d105

Browse files
authored
refactor(sdk)!: Rename storage node event (#2930)
**This is a breaking change.** Fixed typo in event name by renaming `streamRemovedFromFromStorageNode` -> `streamRemovedFromStorageNode`.
1 parent 03a05ec commit b70d105

File tree

6 files changed

+7
-6
lines changed

6 files changed

+7
-6
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ Changes before Tatum release are not documented in this file.
4242
- use `StreamrClient#setStreamMetadata()` and `Stream#setMetadata()` instead
4343
- both methods overwrite metadata instead of merging it
4444
- **BREAKING CHANGE:** Methods `Stream#getMetadata()` and `Stream#getStreamParts()` are async (https://github.com/streamr-dev/network/pull/2883)
45+
- **BREAKING CHANGE:** Rename event `streamRemovedFromFromStorageNode` to `streamRemovedFromStorageNode` (https://github.com/streamr-dev/network/pull/2930)
4546
- Caching changes:
4647
- storage node addresses (https://github.com/streamr-dev/network/pull/2877, https://github.com/streamr-dev/network/pull/2878)
4748
- stream metadata and permissions (https://github.com/streamr-dev/network/pull/2889)

packages/node/src/plugins/storage/StorageEventListener.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,11 @@ export class StorageEventListener {
4141

4242
start(): void {
4343
this.streamrClient.on('streamAddedToStorageNode', this.onAddToStorageNode)
44-
this.streamrClient.on('streamRemovedFromFromStorageNode', this.onRemoveFromStorageNode)
44+
this.streamrClient.on('streamRemovedFromStorageNode', this.onRemoveFromStorageNode)
4545
}
4646

4747
destroy(): void {
4848
this.streamrClient.off('streamAddedToStorageNode', this.onAddToStorageNode)
49-
this.streamrClient.off('streamRemovedFromFromStorageNode', this.onRemoveFromStorageNode)
49+
this.streamrClient.off('streamRemovedFromStorageNode', this.onRemoveFromStorageNode)
5050
}
5151
}

packages/node/test/unit/plugins/storage/StorageConfig.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ describe(StorageConfig, () => {
101101
beforeEach(async () => {
102102
await storageConfig.start()
103103
const addToStorageNodeListener = storageEventListeners.get('streamAddedToStorageNode')!
104-
const removeFromStorageNodeListener = storageEventListeners.get('streamRemovedFromFromStorageNode')!
104+
const removeFromStorageNodeListener = storageEventListeners.get('streamRemovedFromStorageNode')!
105105
addToStorageNodeListener({
106106
streamId: toStreamID('stream-1'),
107107
nodeAddress: CLUSTER_ID,

packages/sdk/src/contracts/StreamStorageRegistry.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ export class StreamStorageRegistry {
108108
initContractEventGateway({
109109
sourceName: 'Removed',
110110
sourceEmitter: chainEventPoller,
111-
targetName: 'streamRemovedFromFromStorageNode',
111+
targetName: 'streamRemovedFromStorageNode',
112112
targetEmitter: eventEmitter,
113113
transformation,
114114
loggerFactory

packages/sdk/src/events.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { StreamMessage } from './protocol/StreamMessage'
88
export interface StreamrClientEvents {
99
streamCreated: (payload: StreamCreationEvent) => void
1010
streamAddedToStorageNode: (payload: StorageNodeAssignmentEvent) => void
11-
streamRemovedFromFromStorageNode: (payload: StorageNodeAssignmentEvent) => void
11+
streamRemovedFromStorageNode: (payload: StorageNodeAssignmentEvent) => void
1212
/** @internal */
1313
encryptionKeyStoredToLocalStore: (keyId: string) => void
1414
/** @internal */

packages/sdk/test/end-to-end/StorageNodeRegistry.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ describe('StorageNodeRegistry', () => {
8181
listenerClient.on('streamAddedToStorageNode', (payload: any) => {
8282
onAddPayloads.push(payload)
8383
})
84-
listenerClient.on('streamRemovedFromFromStorageNode', (payload: any) => {
84+
listenerClient.on('streamRemovedFromStorageNode', (payload: any) => {
8585
onRemovePayloads.push(payload)
8686
})
8787

0 commit comments

Comments
 (0)